Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up common.h #162

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Conversation

JakeHillion
Copy link
Contributor

Summary

Common.h is used in several places and includes the massive drgn header. Split it up for better dependencies.

Test plan

  • `make clobber; make configure-devel && make test'
  • CI

@JakeHillion JakeHillion marked this pull request as ready for review June 7, 2023 18:47
oi/CMakeLists.txt Show resolved Hide resolved
@JakeHillion JakeHillion merged commit 4c331fb into facebookexperimental:main Jun 9, 2023
@JakeHillion JakeHillion deleted the common_h branch June 9, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants