This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
keyPath in FBKVONotificationBlock's change dictionary #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates from facebook base
Create a new key for the keyPath for passing back in the change dictionary. Most useful for the “keyPaths” case so you know which keyPath the block is responding too.
|
Test failure looks valid. I bet is due to the fact that you are doing direct pointer comparison instead of 'isEqual:' |
|
Please fix the try and I'll happily merge it in. |
ghost
added
GH Review: review-needed
CLA Signed
and removed
GH Review: needs-revision
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #113, I've moved the keyPath into the change dictionary to maintain backwards compatibility.