Remove ujson from the .pyre_configuration file #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49093816 |
arthaud
force-pushed
the
export-D49093816
branch
from
3650296 to
6a24406
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49093816 |
arthaud
added a commit
to arthaud/sapp
that referenced
this pull request
Sep 8, 2023
Summary: The open source pyre configuration is broken. This is causing Github CI errors: `Invalid configuration: Invalid path ujson: does not exist.` Differential Revision: D49093816
arthaud
added a commit
to arthaud/sapp
that referenced
this pull request
Sep 8, 2023
Summary: The open source pyre configuration is broken. This is causing Github CI errors: `Invalid configuration: Invalid path ujson: does not exist.` Differential Revision: D49093816
arthaud
force-pushed
the
export-D49093816
branch
2 times, most recently
from
aebd151 to
a04f46b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49093816 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D49093816 |
Summary: The open source pyre configuration is broken. This is causing Github CI errors: `Invalid configuration: Invalid path ujson: does not exist.` Differential Revision: D49093816
arthaud
added a commit
to arthaud/sapp
that referenced
this pull request
Sep 8, 2023
Summary: The open source pyre configuration is broken. This is causing Github CI errors: `Invalid configuration: Invalid path ujson: does not exist.` Differential Revision: D49093816
arthaud
force-pushed
the
export-D49093816
branch
from
a04f46b to
015012d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49093816 |
arthaud
force-pushed
the
export-D49093816
branch
from
015012d to
ccc5e61
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49093816 |
|
This pull request has been merged in db5a428. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Apparently we don't depend on ujson (transitively) anymore.
This is causing Github CI errors:
Invalid configuration: Invalid path ujson: does not exist.Differential Revision: D49093816