Add compile time option to work with utf8 filename strings #4469
Conversation
The default behaviour of rocksdb is to use the *A( functions. These accept filenames in the currently configured system encoding, be it Latin 1, utf8 or whatever. If the Application intends to completely work with utf8 strings internally, converting these to that codepage properly isn't even allways possible. Thus this patch adds a switch to use the *W( functions, which accept UTF-16 filenames, and uses C++11 features to translate the UTF8 containing std::string to an UTF16 containing std::wstring.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@yuslepukhin Hi! Do you mind chime in as see if this change look good to you? Thanks! |
|
@hliu18 Thanks! |
There was a problem hiding this comment.
yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
The default behaviour of rocksdb is to use the
*A(windows API functions.These accept filenames in the currently configured system encoding,
be it Latin 1, utf8 or whatever.
If the Application intends to completely work with utf8 strings internally,
converting these to that codepage properly isn't even always possible.
Thus this patch adds a switch to use the
*W(functions, which acceptUTF-16 filenames, and uses C++11 features to translate the
UTF8 containing std::string to an UTF16 containing std::wstring.
This feature is a compile time options, that can be enabled by setting
WITH_WINDOWS_UTF8_FILENAMESto true.