Add onError to ReactDOMImg to complement onLoad #855
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@spicyj added the the useful
onLoad
, lets complement it withonError
for those times the images doesn't load. :)It is possible that we may want to overload
onLoad
to sometimes emitonError
instead. I've seen people comment in various places that sometimes images fails to load but emitonLoad
with 0 width/height image instead. But I wasn't able to reproduce it myself in IE8-11 and edge versions of browsers.