Don't store mount image on component instance #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got benchmarks? :) |
|
I don't know how this could be slower but let me figure out how to run the benchmarks we just added… |
|
Looks about the same: In this run it looks a little faster for some of them; I ran it again and it was the other way around for the first couple. Not a significant difference. (That's react-bench; I couldn't get Any ideas?) |
|
Follow up pull request for react-art? (I think that's the reason) |
sophiebits
added a commit
to sophiebits/react-art
that referenced
this pull request
Jan 9, 2014
@spicyj For me it prints a bunch of JSONs and exits with "Done, without errors.". Have you tried |
sophiebits
added a commit
to sophiebits/react-art
that referenced
this pull request
Jan 15, 2014
sophiebits
added a commit
to sophiebits/react-art
that referenced
this pull request
Jan 15, 2014
sophiebits
added a commit
to sophiebits/react-art
that referenced
this pull request
Jan 17, 2014
sebmarkbage
added a commit
that referenced
this pull request
Jan 17, 2014
Don't store mount image on component instance
superbuddyy
added a commit
to superbuddyy/react-art-world
that referenced
this pull request
Aug 9, 2022
This was referenced Nov 27, 2023
josephsavona
pushed a commit
that referenced
this pull request
May 15, 2024
Previously, this step just set the mutable range of any alias set including any mutation to the end of the last mutable range of any of the containing identifiers. This change makes it so that the ends are only updated of the ranges that end before the last mutation. Fixes #852
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #851.