support standard "cssFloat" css property #6133
Conversation
For tools that compile CSS may have already converted the name. More info: https://npmjs.com/camelcase-css https://npmjs.com/postcss-js
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| @@ -185,7 +185,7 @@ var CSSPropertyOperations = { | |||
| styles[styleName], | |||
| component | |||
| ); | |||
| if (styleName === 'float') { | |||
| if (styleName === 'float' || styleName === 'cssFloat') { | |||
| styleName = styleFloatAccessor; | |||
| } | |||
There was a problem hiding this comment.
We only need to set styleName to cssFloat if it isn't already cssFloat, so this doesn't actually do anything. i appreciate the thought though.
There was a problem hiding this comment.
It sets it to styleFloat in IE8.
|
Ah true, that's what I get for trying to review from my phone 😬 |
|
:) np |
support standard "cssFloat" css property
|
Thanks! |
For tools that compile CSS may have already converted the name.
More info:
https://npmjs.com/camelcase-css
https://npmjs.com/postcss-js