Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight] Color and badge non-primary environments #31738

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Flight] Color and badge non-primary environments #31738

wants to merge 4 commits into from
+181 −21

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Dec 12, 2024 •
edited
Loading

Stacked on #31737.

Screenshot 2024-12-11 at 8 41 15 PM

When mixing environments (like "use cache" or third party RSC) it's useful to color and badge those components differently to differentiate.

I'm not putting them in separate tracks because when they do actually execute, like cache misses or third party RSCs, they behave like they're part of the same tree.

@sebmarkbage sebmarkbage requested review from gnoff and eps1lon December 12, 2024 01:44
@vercel Vercel
Copy link

vercel bot commented Dec 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 7:40pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 12, 2024
@sebmarkbage sebmarkbage force-pushed the flightenvcolor branch 2 times, most recently from ff997f3 to 492ac59 Compare December 12, 2024 01:47
@react-sizebot
Copy link

react-sizebot commented Dec 12, 2024 •
edited
Loading

Comparing: 130095f...d28201e

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 510.78 kB 510.78 kB = 91.41 kB 91.41 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 515.69 kB 515.69 kB = 92.12 kB 92.12 kB
facebook-www/ReactDOM-prod.classic.js = 595.61 kB 595.61 kB = 105.12 kB 105.12 kB
facebook-www/ReactDOM-prod.modern.js = 585.88 kB 585.88 kB = 103.55 kB 103.55 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +3.78% 99.28 kB 103.03 kB +3.72% 18.97 kB 19.67 kB
oss-experimental/react-client/cjs/react-client-flight.development.js +3.73% 100.60 kB 104.35 kB +3.88% 18.69 kB 19.41 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +3.70% 101.46 kB 105.21 kB +3.66% 19.36 kB 20.07 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js +3.69% 101.76 kB 105.52 kB +3.63% 19.36 kB 20.07 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +3.68% 102.02 kB 105.77 kB +3.65% 19.49 kB 20.20 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +3.63% 103.37 kB 107.13 kB +3.53% 19.69 kB 20.39 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js +3.62% 103.57 kB 107.32 kB +3.65% 19.69 kB 20.41 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +3.54% 106.01 kB 109.76 kB +3.50% 20.15 kB 20.86 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +3.48% 107.76 kB 111.51 kB +3.57% 20.47 kB 21.20 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +3.48% 107.85 kB 111.60 kB +3.56% 20.51 kB 21.24 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +3.45% 108.76 kB 112.51 kB +3.47% 20.41 kB 21.12 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +3.41% 110.09 kB 113.84 kB +3.44% 20.67 kB 21.38 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js +3.02% 99.16 kB 102.15 kB +2.13% 18.82 kB 19.22 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +3.00% 139.63 kB 143.81 kB +3.18% 32.64 kB 33.68 kB
oss-experimental/react-server-dom-parcel/server.browser.js = 0.71 kB 0.25 kB = 0.29 kB 0.16 kB
oss-stable-semver/react-server-dom-parcel/server.browser.js = 0.71 kB 0.25 kB = 0.29 kB 0.16 kB
oss-stable/react-server-dom-parcel/server.browser.js = 0.71 kB 0.25 kB = 0.29 kB 0.16 kB
oss-experimental/react-server-dom-parcel/server.edge.js = 0.70 kB 0.25 kB = 0.29 kB 0.16 kB
oss-stable-semver/react-server-dom-parcel/server.edge.js = 0.70 kB 0.25 kB = 0.29 kB 0.16 kB
oss-stable/react-server-dom-parcel/server.edge.js = 0.70 kB 0.25 kB = 0.29 kB 0.16 kB
oss-experimental/react-server-dom-parcel/server.node.js = 0.76 kB 0.25 kB = 0.30 kB 0.16 kB
oss-stable-semver/react-server-dom-parcel/server.node.js = 0.76 kB 0.25 kB = 0.30 kB 0.16 kB
oss-stable/react-server-dom-parcel/server.node.js = 0.76 kB 0.25 kB = 0.30 kB 0.16 kB
oss-experimental/react-server-dom-parcel/static.browser.js Deleted 0.32 kB 0.00 kB Deleted 0.19 kB 0.00 kB
oss-experimental/react-server-dom-parcel/static.edge.js Deleted 0.31 kB 0.00 kB Deleted 0.18 kB 0.00 kB
oss-experimental/react-server-dom-parcel/static.js Deleted 0.19 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-experimental/react-server-dom-parcel/static.node.js Deleted 0.35 kB 0.00 kB Deleted 0.20 kB 0.00 kB
oss-stable-semver/react-server-dom-parcel/static.browser.js Deleted 0.32 kB 0.00 kB Deleted 0.19 kB 0.00 kB
oss-stable-semver/react-server-dom-parcel/static.edge.js Deleted 0.31 kB 0.00 kB Deleted 0.18 kB 0.00 kB
oss-stable-semver/react-server-dom-parcel/static.js Deleted 0.19 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable-semver/react-server-dom-parcel/static.node.js Deleted 0.35 kB 0.00 kB Deleted 0.20 kB 0.00 kB
oss-stable/react-server-dom-parcel/static.browser.js Deleted 0.32 kB 0.00 kB Deleted 0.19 kB 0.00 kB
oss-stable/react-server-dom-parcel/static.edge.js Deleted 0.31 kB 0.00 kB Deleted 0.18 kB 0.00 kB
oss-stable/react-server-dom-parcel/static.js Deleted 0.19 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable/react-server-dom-parcel/static.node.js Deleted 0.35 kB 0.00 kB Deleted 0.20 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +3.78% 99.28 kB 103.03 kB +3.72% 18.97 kB 19.67 kB
oss-experimental/react-client/cjs/react-client-flight.development.js +3.73% 100.60 kB 104.35 kB +3.88% 18.69 kB 19.41 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +3.70% 101.46 kB 105.21 kB +3.66% 19.36 kB 20.07 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js +3.69% 101.76 kB 105.52 kB +3.63% 19.36 kB 20.07 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +3.68% 102.02 kB 105.77 kB +3.65% 19.49 kB 20.20 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +3.63% 103.37 kB 107.13 kB +3.53% 19.69 kB 20.39 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js +3.62% 103.57 kB 107.32 kB +3.65% 19.69 kB 20.41 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +3.54% 106.01 kB 109.76 kB +3.50% 20.15 kB 20.86 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +3.48% 107.76 kB 111.51 kB +3.57% 20.47 kB 21.20 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +3.48% 107.85 kB 111.60 kB +3.56% 20.51 kB 21.24 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +3.45% 108.76 kB 112.51 kB +3.47% 20.41 kB 21.12 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +3.41% 110.09 kB 113.84 kB +3.44% 20.67 kB 21.38 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js +3.02% 99.16 kB 102.15 kB +2.13% 18.82 kB 19.22 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +3.00% 139.63 kB 143.81 kB +3.18% 32.64 kB 33.68 kB
oss-experimental/react-markup/cjs/react-markup.react-server.development.js +0.73% 514.28 kB 518.03 kB +0.69% 92.61 kB 93.26 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js = 87.82 kB 86.97 kB = 16.59 kB 16.29 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js = 87.87 kB 86.97 kB = 16.62 kB 16.29 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js = 131.84 kB 130.26 kB = 24.58 kB 24.48 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js = 131.84 kB 130.26 kB = 24.58 kB 24.48 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.development.js = 130.39 kB 128.81 kB = 24.32 kB 24.22 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.development.js = 130.39 kB 128.81 kB = 24.32 kB 24.22 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js = 134.38 kB 132.71 kB = 25.14 kB 24.89 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js = 134.38 kB 132.71 kB = 25.14 kB 24.89 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.production.js = 89.09 kB 87.72 kB = 18.62 kB 18.37 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.production.js = 89.09 kB 87.72 kB = 18.62 kB 18.37 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js = 85.96 kB 84.61 kB = 17.97 kB 17.83 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js = 85.96 kB 84.61 kB = 17.97 kB 17.83 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.production.js = 85.60 kB 84.25 kB = 17.87 kB 17.74 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.production.js = 85.60 kB 84.25 kB = 17.87 kB 17.74 kB
oss-experimental/react-server-dom-parcel/server.browser.js = 0.71 kB 0.25 kB = 0.29 kB 0.16 kB
oss-stable-semver/react-server-dom-parcel/server.browser.js = 0.71 kB 0.25 kB = 0.29 kB 0.16 kB
oss-stable/react-server-dom-parcel/server.browser.js = 0.71 kB 0.25 kB = 0.29 kB 0.16 kB
oss-experimental/react-server-dom-parcel/server.edge.js = 0.70 kB 0.25 kB = 0.29 kB 0.16 kB
oss-stable-semver/react-server-dom-parcel/server.edge.js = 0.70 kB 0.25 kB = 0.29 kB 0.16 kB
oss-stable/react-server-dom-parcel/server.edge.js = 0.70 kB 0.25 kB = 0.29 kB 0.16 kB
oss-experimental/react-server-dom-parcel/server.node.js = 0.76 kB 0.25 kB = 0.30 kB 0.16 kB
oss-stable-semver/react-server-dom-parcel/server.node.js = 0.76 kB 0.25 kB = 0.30 kB 0.16 kB
oss-stable/react-server-dom-parcel/server.node.js = 0.76 kB 0.25 kB = 0.30 kB 0.16 kB
oss-experimental/react-server-dom-parcel/static.browser.js Deleted 0.32 kB 0.00 kB Deleted 0.19 kB 0.00 kB
oss-experimental/react-server-dom-parcel/static.edge.js Deleted 0.31 kB 0.00 kB Deleted 0.18 kB 0.00 kB
oss-experimental/react-server-dom-parcel/static.js Deleted 0.19 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-experimental/react-server-dom-parcel/static.node.js Deleted 0.35 kB 0.00 kB Deleted 0.20 kB 0.00 kB
oss-stable-semver/react-server-dom-parcel/static.browser.js Deleted 0.32 kB 0.00 kB Deleted 0.19 kB 0.00 kB
oss-stable-semver/react-server-dom-parcel/static.edge.js Deleted 0.31 kB 0.00 kB Deleted 0.18 kB 0.00 kB
oss-stable-semver/react-server-dom-parcel/static.js Deleted 0.19 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable-semver/react-server-dom-parcel/static.node.js Deleted 0.35 kB 0.00 kB Deleted 0.20 kB 0.00 kB
oss-stable/react-server-dom-parcel/static.browser.js Deleted 0.32 kB 0.00 kB Deleted 0.19 kB 0.00 kB
oss-stable/react-server-dom-parcel/static.edge.js Deleted 0.31 kB 0.00 kB Deleted 0.18 kB 0.00 kB
oss-stable/react-server-dom-parcel/static.js Deleted 0.19 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable/react-server-dom-parcel/static.node.js Deleted 0.35 kB 0.00 kB Deleted 0.20 kB 0.00 kB

Generated by 🚫 dangerJS against 0aa0aee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnoff gnoff Awaiting requested review from gnoff

@eps1lon eps1lon Awaiting requested review from eps1lon

@unstubbable unstubbable Awaiting requested review from unstubbable

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebmarkbage @react-sizebot @facebook-github-bot