Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pull implementations from the right react-dom #27471

Merged
merged 1 commit into from
Oct 5, 2023
Merged

pull implementations from the right react-dom #27471

merged 1 commit into from
Oct 5, 2023

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Oct 5, 2023 •
edited
Loading

should have imported from the stub implementation. this blew up the server rendering stub size (effectively pulling in the entire client bundle)

@gnoff
experimental prefixes were temporarily restored but were still missin…
166087b 
…g from the server rendering stub. This adds them back in.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 5, 2023
@gnoff gnoff requested review from sebmarkbage and acdlite October 5, 2023 15:58
@react-sizebot
Copy link

Comparing: 546178f...166087b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 174.46 kB 174.46 kB = 54.27 kB 54.27 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 176.31 kB 176.31 kB = 54.88 kB 54.88 kB
facebook-www/ReactDOM-prod.classic.js = 564.48 kB 564.48 kB = 99.37 kB 99.37 kB
facebook-www/ReactDOM-prod.modern.js = 548.21 kB 548.21 kB = 96.44 kB 96.44 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.production.min.js = 168.99 kB 3.66 kB = 53.09 kB 1.36 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.production.min.js = 168.91 kB 3.63 kB = 53.06 kB 1.34 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.production.min.js = 170.67 kB 3.66 kB = 53.56 kB 1.36 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.min.js = 169.18 kB 3.46 kB = 52.79 kB 1.25 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.min.js = 169.10 kB 3.44 kB = 52.76 kB 1.22 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.min.js = 170.85 kB 3.47 kB = 53.34 kB 1.25 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.development.js = 1,352.27 kB 18.74 kB = 288.19 kB 4.26 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.development.js = 1,352.24 kB 18.71 kB = 288.16 kB 4.24 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.development.js = 1,289.44 kB 17.83 kB = 285.15 kB 4.14 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.development.js = 1,289.41 kB 17.81 kB = 285.13 kB 4.12 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.development.js = 1,364.02 kB 18.74 kB = 290.26 kB 4.26 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.development.js = 1,300.59 kB 17.84 kB = 287.11 kB 4.14 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/umd/react-dom-server-rendering-stub.production.min.js = 168.99 kB 3.66 kB = 53.09 kB 1.36 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.production.min.js = 168.91 kB 3.63 kB = 53.06 kB 1.34 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.production.min.js = 170.67 kB 3.66 kB = 53.56 kB 1.36 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.min.js = 169.18 kB 3.46 kB = 52.79 kB 1.25 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.min.js = 169.10 kB 3.44 kB = 52.76 kB 1.22 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.min.js = 170.85 kB 3.47 kB = 53.34 kB 1.25 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.development.js = 1,352.27 kB 18.74 kB = 288.19 kB 4.26 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.development.js = 1,352.24 kB 18.71 kB = 288.16 kB 4.24 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.development.js = 1,289.44 kB 17.83 kB = 285.15 kB 4.14 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.development.js = 1,289.41 kB 17.81 kB = 285.13 kB 4.12 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.development.js = 1,364.02 kB 18.74 kB = 290.26 kB 4.26 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.development.js = 1,300.59 kB 17.84 kB = 287.11 kB 4.14 kB

Generated by 🚫 dangerJS against 166087b

@gnoff gnoff merged commit dddfe68 into facebook:main Oct 5, 2023
2 checks passed
@gnoff gnoff deleted the fix-experimental-stub branch October 5, 2023 16:18
Umeshmalik pushed a commit to Umeshmalik/react that referenced this pull request Oct 8, 2023
@gnoff @Umeshmalik
pull implementations from the right react-dom (facebook#27471)
d735745 
should have imported from the stub implementation. this blew up the
server rendering stub size (effectively pulling in the entire client
bundle)
Umeshmalik pushed a commit to Umeshmalik/react that referenced this pull request Oct 8, 2023
@gnoff @Umeshmalik
pull implementations from the right react-dom (facebook#27471)
a03807f 
should have imported from the stub implementation. this blew up the
server rendering stub size (effectively pulling in the entire client
bundle)
@shuding shuding mentioned this pull request Oct 11, 2023
Closed
alunyov pushed a commit to alunyov/react that referenced this pull request Oct 11, 2023
@gnoff @alunyov
pull implementations from the right react-dom (facebook#27471)
cdad694 
should have imported from the stub implementation. this blew up the
server rendering stub size (effectively pulling in the entire client
bundle)
gnoff added a commit to gnoff/next.js that referenced this pull request Oct 13, 2023
@gnoff
- facebook/react#27513
f53355f 
- facebook/react#27514
- facebook/react#27511
- facebook/react#27508
- facebook/react#27502
- facebook/react#27474
- facebook/react#26789
- facebook/react#27500
- facebook/react#27488
- facebook/react#27458
- facebook/react#27471
- facebook/react#27470
- facebook/react#27464
- facebook/react#27456
- facebook/react#27462
- facebook/react#27461
- facebook/react#27460
- facebook/react#27459
- facebook/react#27454
- facebook/react#27457
- facebook/react#27453
- facebook/react#27401
- facebook/react#27443
- facebook/react#27445
- facebook/react#27364
- facebook/react#27440
- facebook/react#27436
@gnoff gnoff mentioned this pull request Oct 13, 2023
Merged
gnoff added a commit to gnoff/next.js that referenced this pull request Oct 13, 2023
@gnoff
Update React from d900fadbf to 09fbee89d
d715ada 
- facebook/react#27513
- facebook/react#27514
- facebook/react#27511
- facebook/react#27508
- facebook/react#27502
- facebook/react#27474
- facebook/react#26789
- facebook/react#27500
- facebook/react#27488
- facebook/react#27458
- facebook/react#27471
- facebook/react#27470
- facebook/react#27464
- facebook/react#27456
- facebook/react#27462
- facebook/react#27461
- facebook/react#27460
- facebook/react#27459
- facebook/react#27454
- facebook/react#27457
- facebook/react#27453
- facebook/react#27401
- facebook/react#27443
- facebook/react#27445
- facebook/react#27364
- facebook/react#27440
- facebook/react#27436
gnoff added a commit to gnoff/next.js that referenced this pull request Oct 13, 2023
@gnoff
Update React from d900fadbf to 09fbee89d
56b4cb6 
- facebook/react#27513
- facebook/react#27514
- facebook/react#27511
- facebook/react#27508
- facebook/react#27502
- facebook/react#27474
- facebook/react#26789
- facebook/react#27500
- facebook/react#27488
- facebook/react#27458
- facebook/react#27471
- facebook/react#27470
- facebook/react#27464
- facebook/react#27456
- facebook/react#27462
- facebook/react#27461
- facebook/react#27460
- facebook/react#27459
- facebook/react#27454
- facebook/react#27457
- facebook/react#27453
- facebook/react#27401
- facebook/react#27443
- facebook/react#27445
- facebook/react#27364
- facebook/react#27440
- facebook/react#27436
gnoff added a commit to gnoff/next.js that referenced this pull request Oct 13, 2023
@gnoff
Update React from d900fadbf to 09fbee89d
5c9d2f4 
- facebook/react#27513
- facebook/react#27514
- facebook/react#27511
- facebook/react#27508
- facebook/react#27502
- facebook/react#27474
- facebook/react#26789
- facebook/react#27500
- facebook/react#27488
- facebook/react#27458
- facebook/react#27471
- facebook/react#27470
- facebook/react#27464
- facebook/react#27456
- facebook/react#27462
- facebook/react#27461
- facebook/react#27460
- facebook/react#27459
- facebook/react#27454
- facebook/react#27457
- facebook/react#27453
- facebook/react#27401
- facebook/react#27443
- facebook/react#27445
- facebook/react#27364
- facebook/react#27440
- facebook/react#27436
gnoff added a commit to gnoff/next.js that referenced this pull request Oct 16, 2023
@gnoff
Update React from d900fadbf to 09fbee89d
a188df1 
- facebook/react#27513
- facebook/react#27514
- facebook/react#27511
- facebook/react#27508
- facebook/react#27502
- facebook/react#27474
- facebook/react#26789
- facebook/react#27500
- facebook/react#27488
- facebook/react#27458
- facebook/react#27471
- facebook/react#27470
- facebook/react#27464
- facebook/react#27456
- facebook/react#27462
- facebook/react#27461
- facebook/react#27460
- facebook/react#27459
- facebook/react#27454
- facebook/react#27457
- facebook/react#27453
- facebook/react#27401
- facebook/react#27443
- facebook/react#27445
- facebook/react#27364
- facebook/react#27440
- facebook/react#27436
ztanner added a commit to vercel/next.js that referenced this pull request Oct 16, 2023
@gnoff @ztanner
@kodiakhq @huozhi
Update React from d900fadbf to 09fbee89d. Removes server context and …
0a80017 
…experimental prefix for server action APIs (#56809)

The latest React canary builds have a few changes that need to be
adopted for compatability.

1. the `useFormState` and `useFormStatus` hooks in `react-dom` and the
`formData` opiont in `react-dom/server` are no longer prefixed with
`experimental_`
2. server content (an undocumented React feature) has been removed. Next
only had trivial intenral use of this API and did not expose a coherent
feature to Next users (no ability to seed context on refetches). It is
still possible that some users used the React server context APIs which
is why this should go into Next 14.

### React upstream changes

- facebook/react#27513
- facebook/react#27514
- facebook/react#27511
- facebook/react#27508
- facebook/react#27502
- facebook/react#27474
- facebook/react#26789
- facebook/react#27500
- facebook/react#27488
- facebook/react#27458
- facebook/react#27471
- facebook/react#27470
- facebook/react#27464
- facebook/react#27456
- facebook/react#27462
- facebook/react#27461
- facebook/react#27460
- facebook/react#27459
- facebook/react#27454
- facebook/react#27457
- facebook/react#27453
- facebook/react#27401
- facebook/react#27443
- facebook/react#27445
- facebook/react#27364
- facebook/react#27440
- facebook/react#27436

---------

Co-authored-by: Zack Tanner <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: Jiachi Liu <[email protected]>
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@gnoff @AndyPengc12
pull implementations from the right react-dom (facebook#27471)
49858ba 
should have imported from the stub implementation. this blew up the
server rendering stub size (effectively pulling in the entire client
bundle)
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@gnoff
pull implementations from the right react-dom (#27471)
c6c6388 
should have imported from the stub implementation. this blew up the
server rendering stub size (effectively pulling in the entire client
bundle)

DiffTrain build for commit dddfe68.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

@acdlite acdlite Awaiting requested review from acdlite

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gnoff @react-sizebot @facebook-github-bot