Allow async blocks in to(Error|Warn)Dev

[eps1lon]

Summary

Allows async blocks in toWarnDev and toErrorDev blocks e.g.

await expect(async () => {
   await act(async () => {})
}).toWarnDev('Some warning')

Note that this means that expect(() => act()).toWarnDev is now async and should be either voided

-expect(() => act()).toWarnDev()
+expect(() => { act() }).toWarnDev()

or awaited.

-expect(() => act()).toWarnDev()
+await expect(() => act()).toWarnDev()

This will enable using toErrorDev in ReactDOMServerIntegration tests and allows explicitly asserting a warning we previously ignored in tests for useSyncExternalStore that should probably not exist in the first place?

How did you test this change?

• CI

[eps1lon]

Intended or should this be a TODO?

[sizebot]

Comparing: 15557fa...28a97ad

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	154.35 kB	154.35 kB	=	48.99 kB	48.99 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	156.28 kB	156.28 kB	=	49.61 kB	49.61 kB
facebook-www/ReactDOM-prod.classic.js	=	533.20 kB	533.20 kB	=	94.44 kB	94.44 kB
facebook-www/ReactDOM-prod.modern.js	=	518.30 kB	518.30 kB	=	92.26 kB	92.25 kB
facebook-www/ReactDOMForked-prod.classic.js	=	533.20 kB	533.20 kB	=	94.44 kB	94.44 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 28a97ad

[eps1lon]

Should act() be chainable?

[gnoff]

fwiw I think this is a great change. maybe we should get someone else to also weigh in thought before merging?

[eps1lon]

fwiw I think this is a great change. maybe we should get someone else to also weigh in thought before merging?

Definitely. Code is a bit of a mess due to the nature of the change. So ideally either there is an existing pattern I should adhere to or others are fine with it.

Also have some questions that are revealed by this change that I'd like to touch upon (chainable act, uSES warnings).

[eps1lon]

Ok to merge as agreed during sync.