Remove checkReact #21132
Merged
Remove checkReact #21132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know what this is useful for but I suspect it was only useful at FB and is not applicable to ES modules at FB nor elsewhere.
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 64983aa...c2288dd Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
gaearon
approved these changes
Mar 30, 2021
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Apr 11, 2021
I don't know what this is useful for but I suspect it was only useful at FB and is not applicable to ES modules at FB nor elsewhere.
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Apr 13, 2021
I don't know what this is useful for but I suspect it was only useful at FB and is not applicable to ES modules at FB nor elsewhere.
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Apr 16, 2021
I don't know what this is useful for but I suspect it was only useful at FB and is not applicable to ES modules at FB nor elsewhere.
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Apr 16, 2021
I don't know what this is useful for but I suspect it was only useful at FB and is not applicable to ES modules at FB nor elsewhere.
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Apr 19, 2021
I don't know what this is useful for but I suspect it was only useful at FB and is not applicable to ES modules at FB nor elsewhere.
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
I don't know what this is useful for but I suspect it was only useful at FB and is not applicable to ES modules at FB nor elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in #10406 but it has no context for why.
I don't know what this is useful for because if you have a circular or error in a module, most CommonJS implementations would return an empty object so this wouldn't actually trigger. The test isn't actually testing a real scenario in Jest.
I suspect it was only useful at FB at some point but is not applicable to ES modules at FB nor elsewhere.
By importing everything we force the whole object to materialize and break module splitting.