Remove unused Scheduler sampling profiler #20833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
bvaughn
commented
Feb 17, 2021
| @@ -217,17 +176,11 @@ function workLoop(hasTimeRemaining, initialTime) { | |||
| currentTask.callback = null; | |||
| currentPriorityLevel = currentTask.priorityLevel; | |||
| const didUserCallbackTimeout = currentTask.expirationTime <= currentTime; | |||
| markTaskRun(currentTask, currentTime); | |||
There was a problem hiding this comment.
We had some unwrapped profiling method calls. Wonder if that was costing us bytes?
| const continuationCallback = callback(didUserCallbackTimeout); | ||
| currentTime = getCurrentTime(); | ||
| if (typeof continuationCallback === 'function') { | ||
| currentTask.callback = continuationCallback; | ||
| markTaskYield(currentTask, currentTime); |
There was a problem hiding this comment.
Ditto for calls to markTaskYield.
bvaughn
changed the title
bvaughn
changed the title
bvaughn
changed the title
|
Comparing: 8fa0ccc...8e50058 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
This was referenced Feb 17, 2021
bvaughn
force-pushed
the
cleanup-scheduler-sampling-profiler
branch
from
72f3857 to
d01743c
Compare
bvaughn
force-pushed
the
cleanup-scheduler-sampling-profiler
branch
from
d01743c to
8e50058
Compare
|
Turns out this is being used within FB so I'm going to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacks on top of #20832
Removes Scheduler's integrated sampling profiler. I'm not aware of this being used within FB so we might as well kill it.
If I'm wrong and it's in use though, happy to just close this PR.
Alternative to #20831.