Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Refactor commitPlacement to recursively insert nodes (#17996)" #18517

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Revert "Refactor commitPlacement to recursively insert nodes (#17996)" #18517

merged 1 commit into from
Apr 7, 2020

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Apr 7, 2020

This reverts commit df5fadd.

I don't know for sure that there is a bug, but we have a crash (T62292977) that started growing soon after the sync with this commit. Maybe let's try reverting it as an experiment, and see if the error goes down?

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 7, 2020
@gaearon gaearon requested review from trueadm and acdlite April 7, 2020 11:47
trueadm
trueadm approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f9e55c3:

Sandbox Source
crazy-wave-lti8l Configuration

@sizebot
Copy link

sizebot commented Apr 7, 2020

Details of bundled changes.

Comparing: 3278d24...f9e55c3

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js -0.1% -0.1% 648.88 KB 648.22 KB 136.1 KB 136 KB UMD_DEV
react-art.production.min.js -0.1% -0.0% 109.64 KB 109.51 KB 33.03 KB 33.01 KB UMD_PROD
react-art.development.js -0.1% -0.1% 552.65 KB 552.02 KB 118.54 KB 118.44 KB NODE_DEV
react-art.production.min.js -0.2% -0.1% 74.62 KB 74.48 KB 22.21 KB 22.19 KB NODE_PROD
ReactART-dev.js -0.1% -0.1% 584.57 KB 583.94 KB 122.5 KB 122.4 KB FB_WWW_DEV
ReactART-prod.js -0.2% -0.2% 240.79 KB 240.29 KB 40.61 KB 40.52 KB FB_WWW_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactTestRenderer-dev.js -0.1% -0.1% 573.94 KB 573.32 KB 120.9 KB 120.81 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% 0.0% 38.72 KB 38.72 KB 9.42 KB 9.43 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% 0.0% 12.74 KB 12.74 KB 3.97 KB 3.97 KB UMD_PROD
react-test-renderer.development.js -0.1% -0.1% 566.6 KB 565.94 KB 117.7 KB 117.61 KB UMD_DEV
react-test-renderer.production.min.js -0.1% 0.0% 74.09 KB 73.99 KB 22.44 KB 22.45 KB UMD_PROD
react-test-renderer.development.js -0.1% -0.1% 540.22 KB 539.59 KB 116.33 KB 116.24 KB NODE_DEV
react-test-renderer.production.min.js -0.2% -0.4% 73.91 KB 73.73 KB 22.15 KB 22.06 KB NODE_PROD

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-server.browser.production.min.js 0.0% -0.0% 23.32 KB 23.32 KB 8.57 KB 8.57 KB UMD_PROD
react-dom.profiling.min.js -0.0% 0.0% 127.64 KB 127.58 KB 39.75 KB 39.76 KB NODE_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.91 KB 4.91 KB 1.64 KB 1.64 KB UMD_DEV
ReactDOM-dev.js -0.1% -0.0% 972.33 KB 971.7 KB 215.42 KB 215.32 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 706 B 705 B UMD_PROD
ReactDOM-prod.js -0.1% -0.1% 407.39 KB 407.07 KB 73.57 KB 73.51 KB FB_WWW_PROD
ReactDOM-profiling.js -0.1% -0.1% 418.2 KB 417.88 KB 75.4 KB 75.34 KB FB_WWW_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.43 KB 4.43 KB 1.55 KB 1.55 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.02 KB 1.02 KB 619 B 617 B NODE_PROD
react-dom-test-utils.development.js 0.0% -0.0% 75.14 KB 75.14 KB 20.12 KB 20.11 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 13.23 KB 13.23 KB 4.9 KB 4.9 KB UMD_PROD
ReactDOMTesting-dev.js -0.1% -0.0% 925.85 KB 925.22 KB 206.06 KB 205.96 KB FB_WWW_DEV
ReactDOMTesting-prod.js -0.1% -0.1% 392.11 KB 391.79 KB 71.34 KB 71.27 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% -0.0% 69.98 KB 69.98 KB 19.61 KB 19.61 KB NODE_DEV
ReactDOMTesting-profiling.js -0.1% -0.1% 392.11 KB 391.79 KB 71.34 KB 71.27 KB FB_WWW_PROFILING
react-dom-server.node.development.js 0.0% -0.0% 148.15 KB 148.15 KB 39.07 KB 39.07 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 13.1 KB 13.1 KB 4.81 KB 4.81 KB NODE_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 23.21 KB 23.21 KB 8.54 KB 8.54 KB NODE_PROD
react-dom.development.js -0.1% -0.0% 931.11 KB 930.45 KB 203.13 KB 203.03 KB UMD_DEV
react-dom.production.min.js -0.0% 🔺+0.1% 123.47 KB 123.41 KB 39.28 KB 39.3 KB UMD_PROD
ReactDOMForked-dev.js -0.1% -0.0% 972.33 KB 971.7 KB 215.42 KB 215.32 KB FB_WWW_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10 KB 10 KB 3.36 KB 3.36 KB UMD_PROD
react-dom.profiling.min.js -0.0% -0.0% 127.29 KB 127.23 KB 40.56 KB 40.56 KB UMD_PROFILING
ReactDOMForked-prod.js -0.1% -0.1% 407.39 KB 407.07 KB 73.57 KB 73.51 KB FB_WWW_PROD
ReactDOMServer-prod.js 0.0% -0.0% 52.11 KB 52.11 KB 12.6 KB 12.59 KB FB_WWW_PROD
react-dom.development.js -0.1% -0.0% 886.59 KB 885.96 KB 200.64 KB 200.54 KB NODE_DEV
ReactDOMForked-profiling.js -0.1% -0.1% 418.2 KB 417.88 KB 75.4 KB 75.34 KB FB_WWW_PROFILING
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.18 KB 5.18 KB 1.7 KB 1.7 KB NODE_DEV
react-dom.production.min.js -0.0% 0.0% 123.66 KB 123.6 KB 38.51 KB 38.52 KB NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 9.75 KB 9.75 KB 3.26 KB 3.25 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% -0.3% 1.17 KB 1.17 KB 669 B 667 B NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-prod.js -0.1% -0.1% 270.55 KB 270.39 KB 46.46 KB 46.42 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js -0.1% -0.1% 282.45 KB 282.29 KB 48.69 KB 48.63 KB RN_OSS_PROFILING
ReactFabric-prod.js 0.0% -0.0% 262.68 KB 262.68 KB 44.98 KB 44.98 KB RN_FB_PROD
ReactNativeRenderer-dev.js -0.1% -0.1% 651.98 KB 651.35 KB 139.81 KB 139.7 KB RN_OSS_DEV
ReactNativeRenderer-dev.js -0.1% -0.1% 654.38 KB 653.75 KB 140.14 KB 140.03 KB RN_FB_DEV
ReactNativeRenderer-prod.js -0.1% -0.1% 270.69 KB 270.53 KB 46.49 KB 46.46 KB RN_FB_PROD
ReactNativeRenderer-profiling.js -0.1% -0.1% 282.59 KB 282.44 KB 48.72 KB 48.65 KB RN_FB_PROFILING

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler-reflection.development.js 0.0% -0.0% 16.22 KB 16.22 KB 4.91 KB 4.9 KB NODE_DEV
react-reconciler-reflection.production.min.js 0.0% -0.2% 2.58 KB 2.58 KB 1.09 KB 1.09 KB NODE_PROD
react-reconciler.development.js -0.1% -0.1% 594.38 KB 593.75 KB 125.23 KB 125.12 KB NODE_DEV
react-reconciler.production.min.js -0.1% -0.1% 80 KB 79.9 KB 23.46 KB 23.43 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against f9e55c3

@sizebot
Copy link

sizebot commented Apr 7, 2020

Details of bundled changes.

Comparing: 3278d24...f9e55c3

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.production.min.js -0.0% 0.0% 119.51 KB 119.45 KB 37.36 KB 37.36 KB NODE_PROD
ReactDOMTesting-profiling.js -0.1% -0.1% 404.08 KB 403.76 KB 73.13 KB 73.07 KB FB_WWW_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.9 KB 4.9 KB 1.64 KB 1.64 KB UMD_DEV
react-dom.profiling.min.js -0.0% 0.0% 123.37 KB 123.31 KB 38.53 KB 38.54 KB NODE_PROFILING
react-dom-test-utils.production.min.js 0.0% -0.0% 13.22 KB 13.22 KB 4.9 KB 4.89 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.19 KB 1.19 KB 699 B 697 B UMD_PROD
react-dom-server.node.development.js 0.0% -0.0% 146.64 KB 146.64 KB 38.85 KB 38.85 KB NODE_DEV
ReactDOMForked-dev.js -0.1% -0.0% 1000.21 KB 999.58 KB 221.43 KB 221.33 KB FB_WWW_DEV
ReactDOMForked-prod.js -0.1% -0.1% 420.45 KB 420.13 KB 75.47 KB 75.41 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.16 KB 5.16 KB 1.69 KB 1.69 KB NODE_DEV
react-dom.development.js -0.1% -0.0% 901.28 KB 900.63 KB 197.85 KB 197.75 KB UMD_DEV
ReactDOMForked-profiling.js -0.1% -0.1% 431.33 KB 431 KB 77.34 KB 77.28 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 154.55 KB 154.55 KB 39.36 KB 39.36 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.5% 1.16 KB 1.16 KB 661 B 658 B NODE_PROD
react-dom.production.min.js -0.0% -0.0% 119.39 KB 119.33 KB 38.17 KB 38.16 KB UMD_PROD
react-dom.profiling.min.js -0.0% -0.1% 123.11 KB 123.05 KB 39.38 KB 39.36 KB UMD_PROFILING
ReactDOMTesting-dev.js -0.1% -0.0% 952.39 KB 951.76 KB 211.66 KB 211.56 KB FB_WWW_DEV
react-dom.development.js -0.1% -0.0% 858 KB 857.37 KB 195.38 KB 195.29 KB NODE_DEV
ReactDOMTesting-prod.js -0.1% -0.1% 404.08 KB 403.76 KB 73.13 KB 73.07 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 145.42 KB 145.42 KB 38.6 KB 38.6 KB NODE_DEV
ReactDOM-dev.js -0.1% -0.0% 1000.21 KB 999.58 KB 221.43 KB 221.33 KB FB_WWW_DEV
ReactDOMServer-dev.js 0.0% 0.0% 156.56 KB 156.56 KB 39.68 KB 39.68 KB FB_WWW_DEV
ReactDOM-prod.js -0.1% -0.1% 420.45 KB 420.13 KB 75.47 KB 75.41 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% -0.0% 69.97 KB 69.97 KB 19.6 KB 19.6 KB NODE_DEV
ReactDOMServer-prod.js 0.0% -0.0% 52.85 KB 52.85 KB 12.76 KB 12.76 KB FB_WWW_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.42 KB 4.42 KB 1.54 KB 1.54 KB NODE_DEV
ReactDOM-profiling.js -0.1% -0.1% 431.33 KB 431 KB 77.34 KB 77.28 KB FB_WWW_PROFILING
react-dom-test-utils.production.min.js 0.0% -0.0% 13.09 KB 13.09 KB 4.8 KB 4.8 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1 KB 1 KB 611 B 609 B NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 9.98 KB 9.98 KB 3.36 KB 3.36 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 53.2 KB 53.2 KB 13.64 KB 13.64 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 9.73 KB 9.73 KB 3.25 KB 3.25 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js -0.1% -0.1% 628.6 KB 627.94 KB 132.4 KB 132.31 KB UMD_DEV
react-art.production.min.js -0.1% -0.0% 107.03 KB 106.9 KB 32.36 KB 32.35 KB UMD_PROD
react-art.development.js -0.1% -0.1% 533.18 KB 532.54 KB 114.77 KB 114.67 KB NODE_DEV
react-art.production.min.js -0.2% -0.0% 72.06 KB 71.93 KB 21.56 KB 21.55 KB NODE_PROD
ReactART-dev.js -0.1% -0.1% 594.63 KB 594 KB 124.49 KB 124.39 KB FB_WWW_DEV
ReactART-prod.js -0.2% -0.2% 248.38 KB 247.89 KB 41.89 KB 41.79 KB FB_WWW_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js -0.1% -0.1% 566.58 KB 565.92 KB 117.69 KB 117.59 KB UMD_DEV
react-test-renderer.production.min.js -0.1% 0.0% 74.06 KB 73.96 KB 22.43 KB 22.43 KB UMD_PROD
react-test-renderer-shallow.development.js 0.0% 0.0% 38.71 KB 38.71 KB 9.42 KB 9.42 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% 0.0% 12.73 KB 12.73 KB 3.96 KB 3.97 KB UMD_PROD
react-test-renderer.development.js -0.1% -0.1% 540.2 KB 539.57 KB 116.32 KB 116.22 KB NODE_DEV
react-test-renderer.production.min.js -0.2% -0.4% 73.89 KB 73.71 KB 22.13 KB 22.05 KB NODE_PROD
ReactTestRenderer-dev.js -0.1% -0.1% 573.93 KB 573.3 KB 120.9 KB 120.8 KB FB_WWW_DEV

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js -0.1% -0.1% 651.96 KB 651.33 KB 139.8 KB 139.69 KB RN_OSS_DEV
ReactNativeRenderer-prod.js -0.1% -0.1% 270.53 KB 270.38 KB 46.45 KB 46.42 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js -0.1% -0.1% 282.44 KB 282.28 KB 48.68 KB 48.62 KB RN_OSS_PROFILING

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js -0.1% -0.1% 572.54 KB 571.91 KB 120.95 KB 120.85 KB NODE_DEV
react-reconciler-reflection.development.js 0.0% -0.0% 16.21 KB 16.21 KB 4.9 KB 4.9 KB NODE_DEV
react-reconciler.production.min.js -0.1% -0.3% 77.04 KB 76.94 KB 22.75 KB 22.69 KB NODE_PROD
react-reconciler-reflection.production.min.js 0.0% -0.2% 2.57 KB 2.57 KB 1.09 KB 1.08 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (stable)

Generated by 🚫 dangerJS against f9e55c3

@gaearon gaearon merged commit e69ca31 into facebook:master Apr 7, 2020
@gaearon gaearon mentioned this pull request Apr 8, 2020
Merged
gaearon added a commit that referenced this pull request Apr 8, 2020
@gaearon
Revert "Revert "Refactor commitPlacement to recursively insert nodes (#…
9bc6431 
…17996)" (#18517)"

This reverts commit e69ca31.
gaearon added a commit that referenced this pull request Apr 8, 2020
@gaearon
Revert "Revert "Refactor commitPlacement to recursively insert nodes (#…
b225d4f 
…17996)" (#18517)" (#18540)

This reverts commit e69ca31.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

@acdlite acdlite Awaiting requested review from acdlite

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaearon @sizebot @trueadm @facebook-github-bot