-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset didReceiveUpdate in beginWork #16359
Conversation
This is a bad bug. It means that we sometimes inherit didReceiveUpdate from a previous component's begin. Effectively this only means that we're overrendering in some cases. We should refactor to get rid of this as a global flag.
No significant bundle size changes to report. Generated by 🚫 dangerJS |
Chatted offline. This is a bug but it only affects the hooks bailout optimization, and only if all of the following are true:
So it's pretty rare. I wrote a test case. I'll submit separately.
|
A test case that hits this for Suspense is added in #16369 |
This is a bad bug. It means that we sometimes inherit
didReceiveUpdate from a previous component's begin.
Effectively this only means that we're overrendering in some cases.
We should refactor to get rid of this as a global flag.
I don’t have a test case because it only showed up as an intermediate state in another test. Maybe we can come up with something simplified.