Use same example code for async effect warning #15118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threepointone
approved these changes
Mar 15, 2019
gaearon
added a commit
to gaearon/react
that referenced
this pull request
Mar 22, 2019
Closed
This was referenced Aug 12, 2019
This was referenced Aug 20, 2019
This was referenced Aug 27, 2019
This was referenced Oct 26, 2019
This was referenced Nov 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know y'all are tired of me tweaking this...
So I tried CRA 3.0 alpha (facebook/create-react-app#6475) and realized it's confusing that both warnings show up with different snippets.
I also think the fully "correct" version is a bit too much for somebody writing this for the first time — and most class examples aren't correct either. So I opted instead to use the simpler first version, and the FAQ link shows you a better one.