Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #14316

Merged
merged 1 commit into from
Jan 21, 2019
Merged

fix typo #14316

merged 1 commit into from
Jan 21, 2019

Conversation

liunian
Copy link
Contributor

@liunian liunian commented Nov 24, 2018

fix typo

@gaearon
Copy link
Collaborator

gaearon commented Jan 21, 2019

lol

@gaearon gaearon merged commit 9c146e6 into facebook:master Jan 21, 2019
gaearon added a commit that referenced this pull request Jan 21, 2019
@gaearon
Revert "fix typo (#14316)"
59021c0 
This reverts commit 9c146e6.
gaearon added a commit that referenced this pull request Jan 21, 2019
@gaearon
Revert "Double-render function components with Hooks in DEV in Strict…
3fbebb2 
…Mode" (#14652)

* Revert "Revert "Disallow reading context during useMemo etc" (#14651)"

This reverts commit 5fce648.

* Revert "Add test coverage for readContext() on the server (#14649)"

This reverts commit fe2ecd2.

* Revert "Warn about incorrect use of useImperativeHandle() (#14647)"

This reverts commit 8f45a7f.

* Revert "Disallow reading context during useMemo etc (#14648)"

This reverts commit 1fcbd22.

* Revert "Warn about refs on lazy function components (#14645)"

This reverts commit 2a084f5.

* Revert "Fix typo (#14560)"

This reverts commit b5a3df6.

* Revert "fix typo (#14316)"

This reverts commit 9c146e6.

* Revert "Mention forwardRef() in <Fn ref={...} /> errors and warnings (#14644)"

This reverts commit baa6d40.

* Revert "Double-render function components with Hooks in DEV in StrictMode (#14643)"

This reverts commit a1414e8.
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
@liunian @jetoneza
fix typo (facebook#14316)
644096c
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
@gaearon @jetoneza
Revert "Double-render function components with Hooks in DEV in Strict…
0c2b751 
…Mode" (facebook#14652)

* Revert "Revert "Disallow reading context during useMemo etc" (facebook#14651)"

This reverts commit 5fce648.

* Revert "Add test coverage for readContext() on the server (facebook#14649)"

This reverts commit fe2ecd2.

* Revert "Warn about incorrect use of useImperativeHandle() (facebook#14647)"

This reverts commit 8f45a7f.

* Revert "Disallow reading context during useMemo etc (facebook#14648)"

This reverts commit 1fcbd22.

* Revert "Warn about refs on lazy function components (facebook#14645)"

This reverts commit 2a084f5.

* Revert "Fix typo (facebook#14560)"

This reverts commit b5a3df6.

* Revert "fix typo (facebook#14316)"

This reverts commit 9c146e6.

* Revert "Mention forwardRef() in <Fn ref={...} /> errors and warnings (facebook#14644)"

This reverts commit baa6d40.

* Revert "Double-render function components with Hooks in DEV in StrictMode (facebook#14643)"

This reverts commit a1414e8.
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
@liunian @n8schloss
fix typo (facebook#14316)
ebbb302
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
@gaearon @n8schloss
Revert "Double-render function components with Hooks in DEV in Strict…
f50daa5 
…Mode" (facebook#14652)

* Revert "Revert "Disallow reading context during useMemo etc" (facebook#14651)"

This reverts commit 5fce648.

* Revert "Add test coverage for readContext() on the server (facebook#14649)"

This reverts commit fe2ecd2.

* Revert "Warn about incorrect use of useImperativeHandle() (facebook#14647)"

This reverts commit 8f45a7f.

* Revert "Disallow reading context during useMemo etc (facebook#14648)"

This reverts commit 1fcbd22.

* Revert "Warn about refs on lazy function components (facebook#14645)"

This reverts commit 2a084f5.

* Revert "Fix typo (facebook#14560)"

This reverts commit b5a3df6.

* Revert "fix typo (facebook#14316)"

This reverts commit 9c146e6.

* Revert "Mention forwardRef() in <Fn ref={...} /> errors and warnings (facebook#14644)"

This reverts commit baa6d40.

* Revert "Double-render function components with Hooks in DEV in StrictMode (facebook#14643)"

This reverts commit a1414e8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdevalapurkar sdevalapurkar sdevalapurkar approved these changes

@vikaskyadav vikaskyadav vikaskyadav approved these changes

@apple77y apple77y apple77y approved these changes

@hg-pyun hg-pyun hg-pyun approved these changes

@prashant-andani prashant-andani prashant-andani approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@liunian @gaearon @prashant-andani @hg-pyun @apple77y @vikaskyadav @sdevalapurkar @facebook-github-bot