Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add chinese translation support #1244

Merged
merged 8 commits into from
Jun 19, 2014
Merged

add chinese translation support #1244

merged 8 commits into from
Jun 19, 2014

Conversation

fxxkscript
Copy link
Contributor

I put the translation file in the docs/docs/01-why-react.zh-CN.md.

Should i put the translation file into another folder or not?

So make it easy, i make the translation file's name end with zh-CN.

@zpao
Copy link
Member

zpao commented Mar 12, 2014

This is awesome! I don't know the best way to present translated content, so I'll need to do a bit of work to expose this. So far the ideas in http://www.sp4ce.net/site/2011/01/15/how-to-have-a-multilingual-website-with-jekyll.html seem the most relevant (there are l10n plugins but focused around strings, not documents).

A couple questions:

  • are you interested in translating more of the documentation?
  • what would be the best way to ensure changes in the english version are flagged for updated translations?

@fxxkscript
Copy link
Contributor Author

@chenglou

I'm new to this project, some words may not be accurate.I will fix these bugs later.

Maybe you can also help me translate these doc better.

@fxxkscript
Copy link
Contributor Author

@zpao

In my spare time, I will translate more docs these days.

Maybe it need a system to notify me when the documents changes.Can Github's hooks do that?

@zpao zpao added the website label Mar 19, 2014
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@zpao
Copy link
Member

zpao commented Jun 19, 2014

I'm going to merge these in so we at least have them, then we can figure out how to manage these later. Sorry for the delay, this just hasn't been a huge priority for us yet.

zpao added a commit that referenced this pull request Jun 19, 2014
add chinese translation support
@zpao zpao merged commit 324d41b into facebook:master Jun 19, 2014
@tiye
Copy link

tiye commented Sep 15, 2014

Is there still a plan to translate docs into Chinese?
Considering that the docs is quite short and I'm using React, I think I can help.

@zpao
Copy link
Member

zpao commented Sep 15, 2014

@jiyinyiyong My concern is that we don't have a process for making sure translations stay up to date. I would be interested in having more translated content but since it's so easy to fall out of sync, I don't want to get stuck in a situation where we're spreading misinformation or outdated information to a group of people.

@tiye
Copy link

tiye commented Sep 16, 2014

@zpao I want to try this one here: https://github.com/react-china/react-docs Maybe I should lock down a version here.
BTW is your docs generated by some tool, each commit looks quite huge?

@zpao
Copy link
Member

zpao commented Sep 16, 2014

The website/docs are generated by Jekyll (for now) from the docs/ directory. We have a readme in there briefly explaining how it works.

Some things not mentioned there:

  • Docs changes should land on master branch
  • Relevant commits about docs (but not all) are cherry-picked to the stable branch (currently 0.11-stable)
    • This allows us to make docs changes for upcoming API changes without publishing incorrect documentation for the current release
  • We generate the site from the stable branch into the gh-pages branch and check in the generated html/etc. We generally have several changes globbed together here. The commits here are noisy, especially for changes that have wide effects (eg blog posts, which affect paginated results and the sidebar so every blog post html needs some change)

@tiye
Copy link

tiye commented Sep 16, 2014

@zpao Really thanks, will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants