Unify the way we fork modules #11711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified the first commit doesn't change a single byte in the bundles. |
|
❤️ This looks great, Dan |
gaearon
changed the title
|
The second commit adds my custom plugin for replacing forks since I figured more control is nicer anyway since it's a pretty important part. |
This does exactly what we need and doesn't suffer from rollup/rollup-plugin-alias#34.
|
Should be ready for review. |
|
Verified the final changes don't change the build either. |
I settled on calling them "forks" since we already have a different concept of "shims".
This was referenced Dec 18, 2020
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unifies the ad hoc way we fork modules so it's easy to see which modules are forked under which conditions, and how to add new forks. This will help us get rid of the existing external dynamic injection that we still rely on in www (after this is merged).