-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add download and hrefLang attributes #1116
Conversation
Might as well fit it into 0.9. Have I said lately that we should do a proper pass through DOM attributes again? |
@zpao I'm starting to feel like the current system is starting to show its limits, is there a good reason why we simply don't accept all unknown names as attributes, |
@syranide I'm concerned that would result in subtly broken updates for many of the attributes. |
@spicyj Definitely true, it was mostly based on the pattern of most of the "properties" being just regular "attributes" with no additional checks. I think the real solution would be to maintain a list per "category of tags", that way an input cannot have |
Is it a problem if I specify |
@spicyj Nope, but once I see your point, but it seems kind of weird to me to maintain a huge list of all possible properties for all "technologies", it seems like the current solution was intended for only HTML (and not SVG, etc). As opposed to keeping it to a per-technology per-component basis. Intuitively, done right the size cost of maintaining it per component should be minimal. Perhaps I'm overthinking it, but it seems really unwieldy. |
Agree that HTML and SVG attributes should be separate. |
Add download and hrefLang attributes
Fixes #1115.