-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rendering into shadow root #11037
Conversation
Deploy preview ready! Built with commit f94bed8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, should we add a small test for mounting into a document fragment?
@gaearon do we need to update
|
I don't think we need to. I intentionally changed it to skip that check since it's valid to render anything into a fragment. |
If you'd like as a follow up :-) |
}` | ||
)(React, ReactDOM, HelloWorld); | ||
|
||
customElements.define('my-element', MyElement); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaearon this is causing the fixtures to fail in browsers that don't have customElements
. We should either provide a polyfill or only run this fixture in browsers that support the custom element registry.
Fixes #11017.
Before:
After: