Use single entry point for SSR via browser field #10362
Conversation
| @@ -6,7 +6,7 @@ | |||
| * LICENSE file in the root directory of this source tree. An additional grant | |||
| * of patent rights can be found in the PATENTS file in the same directory. | |||
| * | |||
| * @providesModule ReactDOMServerEntry | |||
| * @providesModule ReactDOMServerBrowserEntry | |||
| */ | |||
|
|
|||
There was a problem hiding this comment.
We could add shims that throw for renderToStream() APIs here. Then it's less mysterious.
There was a problem hiding this comment.
Yes that would be nice.
| "test-utils.js", | ||
| "unstable-native-dependencies.js", | ||
| "cjs/", | ||
| "umd/" | ||
| ], | ||
| "browser": { |
There was a problem hiding this comment.
It might be nicer to do this with a more public browser entry point instead of the internal package details (personally I'd prefer not exposing those as separate files at all and just inline them).
With a public entry point it's at least possible to manually require the browser version if you need to. This encourages require to the internal implementation details instead.
I wanted to do that but couldn’t decide on the naming. I like yours. |
|
Just tested in Node, webpack, and browserify, and it works as expected. |
|
This breaks on CI now. https://github.com/facebook/react/blob/master/scripts/circleci/upload_build.sh#L11-L12 |
|
Oops, sorry 😛 |
Haven’t verified this works yet, will test tomorrow.
But that’s the basic idea.