Exclude src/node_modules from .gitignore. #10028
Merged
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/node_modules
is a directory of package stubs that is checked in for the test suite to use. Unfortunately, though, there is anode_modules
line in.gitignore
, which means thesrc/node_modules
directory is ignored by git.I ran into this in #10024, where I had to add a new file to
src/node_modules
, but because of the.gitignore
, I failed to commit the new file. (Obviously, neithergit commit -a
norgit stage -A
will add an ignored file.) My failure to commit the new file lead to a confusing situation where tests were working locally but not in CI, and it took me an hour or two to figure out what was going on.This PR just excludes
src/node_modules
from.gitignore
so that this kind of thing won't happen again.Thanks for all your work!