Set return pointer of deleted tree

When deleting a host node, we follow the return path to find the nearest mounted host parent. Which means the return pointer of the deleted tree must be correct in the mutation phase.
facebook · Mar 5, 2021 · 01ece92 · 01ece92
1 parent 80076d7
commit 01ece92
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.new.js b/packages/react-reconciler/src/ReactFiberCommitWork.new.js
@@ -1964,6 +1964,10 @@ function commitMutationEffects_begin(
     if (deletions !== null) {
       for (let i = 0; i < deletions.length; i++) {
         const childToDelete = deletions[i];
+        // When deleting a host node, we follow the return path to find the
+        // neartest mounted host parent. Which means the return pointer of
+        // the deleted tree must be correct.
+        childToDelete.return = fiber;
         if (__DEV__) {
           invokeGuardedCallback(
             null,

diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.old.js b/packages/react-reconciler/src/ReactFiberCommitWork.old.js
@@ -1964,6 +1964,10 @@ function commitMutationEffects_begin(
     if (deletions !== null) {
       for (let i = 0; i < deletions.length; i++) {
         const childToDelete = deletions[i];
+        // When deleting a host node, we follow the return path to find the
+        // neartest mounted host parent. Which means the return pointer of
+        // the deleted tree must be correct.
+        childToDelete.return = fiber;
         if (__DEV__) {
           invokeGuardedCallback(
             null,