FlatList example fixes #38739
Closed
FlatList example fixes #38739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47978628 |
Base commit: a34ce64 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Aug 3, 2023
Summary: Pull Request resolved: facebook#38739 1. The separator here adds horizontal width, except when the cell is tapped. This is meant to be a visual effect for vertical FlatList, but makes `getItemLayout` incorrect and results in odd layout shifts. Do not use when horizontal. 2. Disabling "fixed height" leads to a barrage of errors because the example sets `initialScrollIndex` but does not set an `onScrollToIndexFailed` prop. Changelog: [Internal] Reviewed By: rozele Differential Revision: D47978628 fbshipit-source-id: 708cae0600535f9eecd3ac422b93736edd80ba72
NickGerleman
force-pushed
the
export-D47978628
branch
from
eb52da5 to
66948a5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47978628 |
Summary: Pull Request resolved: facebook#38739 1. The separator here adds horizontal width, except when the cell is tapped. This is meant to be a visual effect for vertical FlatList, but makes `getItemLayout` incorrect and results in odd layout shifts. Do not use when horizontal. 2. Disabling "fixed height" leads to a barrage of errors because the example sets `initialScrollIndex` but does not set an `onScrollToIndexFailed` prop. Changelog: [Internal] Reviewed By: rozele Differential Revision: D47978628 fbshipit-source-id: 33efab842bca387f1388a51ee48b3784e66d949d
NickGerleman
force-pushed
the
export-D47978628
branch
from
66948a5 to
9a81411
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47978628 |
|
This pull request has been merged in 306ca02. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
getItemLayoutincorrect and results in odd layout shifts. Do not use when horizontal.initialScrollIndexbut does not set anonScrollToIndexFailedprop.Changelog: [Internal]
Differential Revision: D47978628