Update new_architecture.rb for React-ImageManager

[billnbell]

Summary:

This added React-ImageManager to the use_frameworks! - a lot of rpm modules podspec need this.

Changelog:

[iOS] [FIXED] - Add React-ImageManager path to work with use_frameworks!

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests

Test Plan:

Should not be breaking - it will add to the header_search_paths React-ImageManager

[facebook-github-bot]

Hi @billnbell!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[billnbell]

I signed the CLA

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,885,449	-2
android	hermes	armeabi-v7a	7,935,798	+1
android	hermes	x86	9,281,970	-1
android	hermes	x86_64	9,185,456	-1
android	jsc	arm64-v8a	9,473,452	+0
android	jsc	armeabi-v7a	8,416,807	+0
android	jsc	x86	9,456,195	-1
android	jsc	x86_64	9,772,407	-1

Base commit: cbf9408
Branch: main

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[cipolleschi]

Hi there! Thanks for taking the time for doing this.
I think we have also to update the ruby tests, otherwise the CI will stay red. I think this is the test that needs to be updated.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[billnbell]

Hi there! Thanks for taking the time for doing this.
I think we have also to update the ruby tests, otherwise the CI will stay red. I think this is the test that needs to be updated.

Yeah I added that one - let's see what the tests do

[cipolleschi]

/rebase

[billnbell]

OK rebased.

[cipolleschi]

I don't know what's going on with the CI. Main is green, I don't understand why this branch can't build correctly... :/

[cipolleschi]

/rebase

[billnbell]

What do you want me to do for /rebase ? I am not getting it.

[billnbell]

I merged from Facebook into main and merged that and rebased into patch-2. Should be rebased.

[cipolleschi]

Cool! Now the CI is running properly!

There are some ruby tests failures, which are expected!

You can run ruby tests locally on your machines:

1. navigate to: react-native/packages/react-native/scripts
2. run ./run_ruby_tests.sh

This will highlights the failures locally and you should be able to fix the tests and update the PR! ;)

Thanks again for taking the time to work on this!

[billnbell]

ok fixed those 2.

[billnbell]

ok good

[cipolleschi]

What do you want me to do for /rebase ? I am not getting it.

I'm sorry! 😓

Leaving a comment /rebase on a React Native PR triggers a github action that automatically rebase the PR on top of main, if possible.

That's why I was leaving those messages: I was asking the CI to rebase to rerun the CI and verify that it gets green!

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[github-actions]

This pull request was successfully merged by @billnbell in 8a63b91.

^{When will my fix make it into a release? | Upcoming Releases}