Hermes: Use shared JSI from React Native on iOS #33885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D36567471 |
|
This pull request was exported from Phabricator. Differential Revision: D36567471 |
hramos
added a commit
to hramos/react-native
that referenced
this pull request
May 21, 2022
Summary: Pull Request resolved: facebook#33885 When building Hermes for React Native, point to the React Native JSI location to ensure both React Native and Hermes use the exact same version of JSI. Changelog: [iOS] [Changed] - When Hermes is enabled, it will use the same copy of JSI as React Native Differential Revision: D36567471 fbshipit-source-id: a0626aa3cf370a15bea7533231b189a332f538b2
|
This pull request was exported from Phabricator. Differential Revision: D36567471 |
hramos
added a commit
to hramos/react-native
that referenced
this pull request
May 21, 2022
Summary: Pull Request resolved: facebook#33885 When building Hermes for React Native, point to the React Native JSI location to ensure both React Native and Hermes use the exact same version of JSI. Changelog: [iOS] [Changed] - When Hermes is enabled, it will use the same copy of JSI as React Native Differential Revision: D36567471 fbshipit-source-id: 806693037683c9ec50726edbb74b030e9e93e886
|
This pull request was exported from Phabricator. Differential Revision: D36567471 |
hramos
added a commit
to hramos/react-native
that referenced
this pull request
May 21, 2022
Summary: Pull Request resolved: facebook#33885 When building Hermes for React Native, point to the React Native JSI location to ensure both React Native and Hermes use the exact same version of JSI. Changelog: [iOS] [Changed] - When Hermes is enabled, it will use the same copy of JSI as React Native Differential Revision: D36567471 fbshipit-source-id: fc7f0c68427e78957cd882ae646edf2ba00d2527
|
This pull request was exported from Phabricator. Differential Revision: D36567471 |
hramos
added a commit
to hramos/react-native
that referenced
this pull request
May 22, 2022
Summary: Pull Request resolved: facebook#33885 When building Hermes for React Native, point to the React Native JSI location to ensure both React Native and Hermes use the exact same version of JSI. Changelog: [iOS] [Changed] - When Hermes is enabled, it will use the same copy of JSI as React Native Differential Revision: D36567471 fbshipit-source-id: 5d1fda8a2576f1069795f650460480511717283b
|
This pull request was exported from Phabricator. Differential Revision: D36567471 |
hramos
added a commit
to hramos/react-native
that referenced
this pull request
Jun 7, 2022
Summary: Pull Request resolved: facebook#33885 When building Hermes for React Native, point to the React Native JSI location to ensure both React Native and Hermes use the exact same version of JSI. Changelog: [iOS] [Changed] - When Hermes is enabled, it will use the same copy of JSI as React Native Differential Revision: D36567471 fbshipit-source-id: 210d9a6739881ea2e81d29b25b00607d0fb3eeb3
Base commit: a0e6ffe |
Base commit: df80ed4 |
|
This pull request was exported from Phabricator. Differential Revision: D36567471 |
hramos
added a commit
to hramos/react-native
that referenced
this pull request
Jun 8, 2022
Summary: Pull Request resolved: facebook#33885 When building Hermes for React Native, point to the React Native JSI location to ensure both React Native and Hermes use the exact same version of JSI. Changelog: [iOS] [Changed] - When Hermes is enabled, it will use the same copy of JSI as React Native Reviewed By: cipolleschi Differential Revision: D36567471 fbshipit-source-id: 6ec927d8fb5402f8511bcd6e6b3cb04111391e6a
|
This pull request was exported from Phabricator. Differential Revision: D36567471 |
hramos
added a commit
to hramos/react-native
that referenced
this pull request
Jun 8, 2022
Summary: Pull Request resolved: facebook#33885 When building Hermes for React Native, point to the React Native JSI location to ensure both React Native and Hermes use the exact same version of JSI. Changelog: [iOS] [Changed] - When Hermes is enabled, it will use the same copy of JSI as React Native Reviewed By: cipolleschi Differential Revision: D36567471 fbshipit-source-id: d0eb559aba603a0848a8b5474fbe01ce3ad103ff
Differential Revision: D36985477 fbshipit-source-id: eec0d050224b89dd6cc8ed434274bfa27ac20982
Differential Revision: D36989241 fbshipit-source-id: 3013353c646de81e18ef3b74b26a43d8a7c37507
Summary: Pull Request resolved: facebook#33885 When building Hermes for React Native, point to the React Native JSI location to ensure both React Native and Hermes use the exact same version of JSI. Changelog: [iOS] [Changed] - When Hermes is enabled, it will use the same copy of JSI as React Native Reviewed By: cortinico, cipolleschi Differential Revision: D36567471 fbshipit-source-id: ef5a12fe33e79ba69fd51ab1fa5f553afc52f2ce
|
This pull request was exported from Phabricator. Differential Revision: D36567471 |
|
This pull request was successfully merged by @hramos in 340612a. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When building Hermes for React Native, point to the React Native JSI location to ensure both React Native and Hermes use the exact same version of JSI.
The Hermes build scripts are meant to be invoked from the root of the hermes source directory. Not doing so can lead to build failures, so a PWD check has been added to enforce this assumption.
Changelog:
[iOS] [Changed] - When Hermes is enabled, it will use the same copy of JSI as React Native
Differential Revision: D36567471