-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump react to 16.9.0 #27060
Bump react to 16.9.0 #27060
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you might want to sync react-test-renderer
version as well?
🤦♂ doing it now |
should I also update the other deps too? |
Please update the |
Alright, I upgraded the rest of the deps too, to the versions they should be, and I added the |
Hey everyone! React inside of RN can only be updated by the React Native team itself because it has some dependencies with FB infra but also because the React specific code in React Native needs to be updated at the same time. In this case, the release was cut more than two months ago when 16.8.1 was still current. Updating React without updating the renderers will lead to problems and making such a large change in a patch release of a current stable release is very risky. We will soon update master to React 16.9.0 and the next stable release will ship with that. I'm curious however, why did this PR receive so many accepts? Is there a blocking bug in the current version of React in React Native that is causing issues? |
FWIW, even if there was, the |
It's about this: Line 84 in 35001d2
It turned out, that during the 0.61 release the template wasn't synchronized with the root package.json. This results in legacy init and new init generating projects with different versions of This caused confusing diffs in the Upgrade Helper. I guess @pvinis can alter the diffs manually again, but this desynchronization shouldn't ever happen. It's not a breaking change by any means. The
|
OK, that was the missing context. Makes sense then. Thanks for explaining! |
Thanks for the thorough explanation. |
Summary
When using
npx react-native init Bla
, the react version that is installed there is 16.8.1 instead of the recommended 16.9.0.This PR is to fix that.
Changelog
[General] [Fixed] - Updated React version to 16.9.0
Test Plan
Run
npx react-native init Bla
using this PR somehow, and see if the correct react version is pulled in.