Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Animation EndResult callback to return Promise #25793

Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Libraries/Animated/src/NativeAnimatedModule.js
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@ import type {TurboModule} from '../../TurboModule/RCTExport';
import * as TurboModuleRegistry from '../../TurboModule/TurboModuleRegistry';

type EndResult = {finished: boolean};
type EndCallback = (result: EndResult) => void;
type EndCallback = (result: EndResult) => any;
draperunner marked this conversation as resolved.
Show resolved Hide resolved

export type EventMapping = {|
nativeEventPath: Array<string>,
2 changes: 1 addition & 1 deletion Libraries/Animated/src/animations/Animation.js
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@ const NativeAnimatedHelper = require('../NativeAnimatedHelper');
import type AnimatedValue from '../nodes/AnimatedValue';

export type EndResult = {finished: boolean};
export type EndCallback = (result: EndResult) => void;
export type EndCallback = (result: EndResult) => any;
draperunner marked this conversation as resolved.
Show resolved Hide resolved

export type AnimationConfig = {
isInteraction?: boolean,