-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State update breaks CJK language input mode in single-line TextInput, after iOS 15 #32503
Labels
Component: TextInput
Related to the TextInput component.
Needs: Attention
Issues where the author has responded to feedback.
Platform: iOS
iOS applications.
Resolution: Locked
This issue was locked by the bot.
Comments
react-native-bot
added
Component: TextInput
Related to the TextInput component.
Platform: iOS
iOS applications.
Needs: Author Feedback
Needs: Environment Info
Please run `react-native info` and edit your issue with that command's output.
and removed
Needs: Triage 🔍
labels
Oct 30, 2021
|
For any others suffer with this issue, here is the patch-package file from the PR #32523: https://gist.github.com/bernard-kms/8f6bb978b3609b7f140467d59074a0fc |
github-actions
bot
added
Needs: Attention
Issues where the author has responded to feedback.
and removed
Needs: Author Feedback
labels
Nov 23, 2021
react-native-bot
removed
the
Needs: Environment Info
Please run `react-native info` and edit your issue with that command's output.
label
Nov 23, 2021
ShikaSD
pushed a commit
that referenced
this issue
Feb 22, 2022
Summary: <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> Fix #32503 Updating the attributed text in TextView/TextField while inputting Korean language will break input mechanism of the Korean alphabet. This results unexpected text input. This PR supersedes the previous fixes: #19809, #22546 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [iOS] [Fixed] - Fix a broken input for the Korean alphabet in TextInput Pull Request resolved: #32523 Test Plan: https://user-images.githubusercontent.com/20317121/140013434-1674c391-54d6-4410-b4c1-c633697e639d.mov Reviewed By: lunaleaps, sammy-SC Differential Revision: D32470543 Pulled By: philIip fbshipit-source-id: e7e34bd362fa2ab2ca579103db01ad8d1a891c35
ShikaSD
pushed a commit
that referenced
this issue
Feb 24, 2022
Summary: <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> Fix #32503 Updating the attributed text in TextView/TextField while inputting Korean language will break input mechanism of the Korean alphabet. This results unexpected text input. This PR supersedes the previous fixes: #19809, #22546 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [iOS] [Fixed] - Fix a broken input for the Korean alphabet in TextInput Pull Request resolved: #32523 Test Plan: https://user-images.githubusercontent.com/20317121/140013434-1674c391-54d6-4410-b4c1-c633697e639d.mov Reviewed By: lunaleaps, sammy-SC Differential Revision: D32470543 Pulled By: philIip fbshipit-source-id: e7e34bd362fa2ab2ca579103db01ad8d1a891c35
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Component: TextInput
Related to the TextInput component.
Needs: Attention
Issues where the author has responded to feedback.
Platform: iOS
iOS applications.
Resolution: Locked
This issue was locked by the bot.
Description
This is a somewhat historic issue which has been reported several times. There were also PRs to fit it.
-[UITextView setAttributedString:]
while user is typing #19809It seems that there was some internal behavior changes in UIKit
TextField
after iOS 15, andsetSelectedTextRange
call breaks input mode of CJK languages.react-native/Libraries/Text/TextInput/RCTBaseTextInputView.m
Lines 152 to 165 in c8b83d4
I'm now trying to resolve this issue, but it is hard to find a safe workaround. Any suggestions or ideas would be appreciated.
Version
0.65.1
Output of
react-native info
Steps to reproduce
Type some Korean characters in TextInput in iOS 15, such as "하늘". Then move the cursor to the beginning of the text, and then type any text. Let's say I typed "파란" (characters
ㅍ
,ㅏ
,ㄹ
,ㅏ
,ㄴ
) this time. The expected text is "파란하늘" However, the actual result is "ㅍㅏㄹㅏㄴ하늘"Snack, code example, screenshot, or link to a repository
-[UITextView setAttributedString:]
while user is typing #19809The text was updated successfully, but these errors were encountered: