React Native 0.61.1 and iOS 13.1.2 leads to lots of unneeded relaunches of our app #26696

bobber205 · 2019-10-02T23:33:26Z

Last week we upgraded to the latest version of React. Around the same time my boss updated his phone to iOS 13.1.2 (got a new phone)

I have a iPhone 5S on my desk with iOS 12.x (whatever the latest in that branch is I updated it today)

I also run the app on my Android 10 phone.

After almost no time at all with the app not focused my boss's phone relaunches the app as if the phone just rebooted. Splash screen and everything. This doesn't happen on the very old iPhone 5. Not on Android either. Of course this relaunch can happen under certain circumstances that are reasonable. For instance my boss will open our app, open up IG and TW, then go back to our app and it relaunches.

We narrowed it down to our upgrade of .60.x to 0.61.1 last Thursday.

This is a very jarring UX issue. I'm not sure how to produce a reproducible use case since it depends on the latest version of iOS and I'm really busy trying to fix other bugs atm related to the new version of iOS. Has anyone else experienced this?

react-native-bot · 2019-10-02T23:35:07Z

Thanks for submitting your issue. Can you take another look at your description and make sure the issue template has been filled in its entirety?

👉 Click here if you want to take another look at the Bug Report issue template.

radko93 · 2019-10-03T09:11:22Z

Are you sure your app is not crashing in the background? Do you have any crash reporting service enabled?

bobber205 · 2019-10-03T20:38:24Z

@radko93 Pretty sure it's not crashing. I've narrowed it down to a commit that was responsible for the 0.61 upgrade -- before that commit doesn't matter how long you put the app in the background (say 10 minutes) it's still active when you come back.

We've noticed as little as 1 minute timed of launching the app going over to Instagram and doing literally nothing for a minute then back to our app, relaunch.

We have no background processes for this app. And while we don't have a ton of devices to test on at the moment we have only noticed it on the latest iOS.

oleksandr-dziuban · 2019-10-07T19:57:24Z

@bobber205 @radko93 Have almost same issue
I have described it in #26746

Just app is really crashing on iOS 13.1.2 when device is sleeping or app just staying in background
Stracktrace crash report is available in my issue

bobber205 · 2019-10-07T20:09:48Z

@oleksandr-dziuban

radko93 · 2019-10-08T05:54:22Z

Are you using Websockets @bobber205 @oleksandr-dziuban ?

oleksandr-dziuban · 2019-10-08T07:05:51Z

Are you using Websockets @bobber205 @oleksandr-dziuban ?

No, I don't use Websockets.

For data transport I use GraphQL based on Apollo Client without Websockets.
For Native features I use these libraries only:

    "@react-native-community/async-storage": "1.6.2",
    "@react-native-community/netinfo": "4.2.2",
    "react-native": "0.61.2",
    "react-native-dynamic-fonts": "0.3.1",
    "react-native-image-crop-picker": "0.25.2",
    "react-native-keyboard-aware-scroll-view": "0.9.1",
    "react-native-popup-menu": "0.15.6",
    "react-native-render-html": "4.1.2",
    "react-native-restart": "0.0.13",
    "react-native-router-flux": "4.0.6",
    "react-native-share": "2.0.0",
    "react-native-sqlite-storage": "4.1.0",
    "react-native-svg": "9.9.5",
    "react-native-version-number": "0.3.6",
    "react-native-view-shot": "3.0.2",
    "react-native-webview": "7.2.7",
    "react-native-woodpicker": "0.0.17",
    "rn-fetch-blob": "0.11.2",

There are no background processes in the app.

oleksandr-dziuban · 2019-10-08T07:15:36Z

@radko93 Just interesting, I have found how to reproduce that even on iOS 13.0 Simulator with Xcode 11.0

Just open an application
Work with it some time
After this click on hardware "ON/OFF" button on Simulator
Wait 1-2 minutes to emulate sleep mode
Unlock device again
Application will be crashed

Veeery tricky issue....

oleksandr-dziuban · 2019-10-08T07:56:32Z

@radko93 Yes, very easy to reproduce even on newest iOS 13.1 Simulator (Xcode 11.1)

Also reproduced on iOS 13.1 Simulator iPhone 11 (Xcode 11.1):

Open an application
Emulate device sleep mode: click on hardware "ON/OFF" button on Simulator
Screen should be black now
Wait 1-2 minutes in this sleep mode
Unlock device again
Application will be crashed without any error

For best crash detection I use react-native-debugger with Memory Tab: when application will be crashed - we will see that in Select Javascript Area VM instance field

radko93 · 2019-10-08T08:25:11Z

@oleksandr-dziuban it's complicated because I cannot reproduce it for now with my app on RN 0.61.2.

oleksandr-dziuban · 2019-10-08T08:28:16Z

Did you wait 1-2 minutes in sleep mode on simulator?

oleksandr-dziuban · 2019-10-08T08:28:42Z

Maybe this is native libraries specific issue? Some library is crashing in sleep mode, maybe react-native-webview, maybe netinfo.... Tricky case....

radko93 · 2019-10-08T08:31:51Z

@oleksandr-dziuban I wait 10 or more minutes on iPhone 6s with latest iOS (Release build). Might be netinfo, try to comment it out. Try to comment out different things and see if it helps.

oleksandr-dziuban · 2019-10-08T08:38:42Z

@radko93

I'm using Apollo Client for GraphQL data transport, it can use Websockets under the hood for GraphQL subscriptions

Maybe this causing crash

Additionally I will comment all Native packages one by one to check

oleksandr-dziuban · 2019-10-08T08:48:54Z

Disabled NetInfo, WebView - nothing changed

oleksandr-dziuban · 2019-10-08T09:15:16Z

@radko93 I have reproduced this even on fresh react-native app without any additional code!

Steps:

Use iOS 13.0 or 13.1 Simulator, Xcode 11.0 or 11.1, [email protected]
Generate fresh app: react-native init TestApp
Run iOS app in Simulator: react-native run-ios --simulator="iPhone 11"
Wait until application will be assembled and home screen activated
Click on Hardware Power Button on the right side in Simulator, device will activate sleep mode
Wait ~ 1 min and Unlock Simulator screen
Application will be crashed

SYoder1 · 2019-10-08T14:34:51Z

This is the same issue that I am seeing, but I am on react-native: 0.59.8

bobber205 · 2019-10-08T16:11:49Z

Are you using Websockets @bobber205 @oleksandr-dziuban ?

i don't use Websockets either.

bobber205 · 2019-10-08T16:13:46Z

@SYoder1 Good to know! I think that means this is a React Native + newest version of iOS issue not specific to a version of react (seems that way anyway)

SYoder1 · 2019-10-08T16:18:33Z

@bobber205 I am also not using Websockets

oleksandr-dziuban · 2019-10-08T16:46:22Z

@bobber205 Yes, I think in iOS 13 we have new mechanism for sleep/awake in apps and something went wrong now with react-native apps.

ozgursoy · 2019-10-08T17:00:31Z

@oleksandr-dziuban I tried but my app did not crash.
But i added some capabilities on Xcode

Background Modes is enabled
Audio, Airplay ...
Background Fetch
Remote notifications

and these are selected

oleksandr-dziuban · 2019-10-08T17:40:15Z

I will try to do the same

oleksandr-dziuban · 2019-10-08T20:08:20Z

@Farad4y @bobber205 I have added this capabilities.
I see a bit different behaviour now:
Application is not crashing, it is in Active App List, but when I select it again it starting from scratch.
Looks like app was totally refreshed, something like when RAM is not enough to keep app active.

bobber205 · 2019-10-08T20:16:46Z

@oleksandr-dziuban That's exactly what we're seeing.

radko93 · 2019-10-30T19:49:34Z

@minhtc thanks for investigating, this might be the commit that is causing this issue 3382984#diff-29f34a4d1c9b73a44351941dae6056c8

bobber205 · 2019-10-30T20:15:06Z

Anyway known way (hard or easy) to disable that functionality for consumers who don't need it? 🙏

radko93 · 2019-10-30T20:50:32Z

I submitted a PR to fix that for 0.61.x, You can upvote it there #27065 . If it gets merged then it will be available in 0.61.4.

Summary: Related #23674, in that PR, we imported background timer support, but it's not sufficient, I think the reason that works is because it enable the `Background Modes` and do some background tasks, for the users who don't enable it, timer would pause immediately before goes into background. To fix it, we can mark a background task when goes into background, it can keep app active for minutes, try best to support timing when in background. cc. cpojer . ## Changelog [iOS] [Fixed] - Timing: Fixes timer when app get into background Pull Request resolved: #24649 Differential Revision: D15554451 Pulled By: cpojer fbshipit-source-id: a33f7afe6b63d1a4fefcb7098459aee0c09145da

This PR reverts commit 3382984 that is causing #26696 #26995.

zhongwuzw · 2019-11-02T03:22:55Z

Hi, anyone can try new a project(not include RN), just begin a background task to see wether it terminated by system? code like 3382984#diff-29f34a4d1c9b73a44351941dae6056c8R150-R157.

zhongwuzw · 2019-11-02T03:43:10Z

I reviewed the timer module again, I may suspect there have thread-safe issue, @bobber205 @oleksandr-dziuban can you guys can help to dig in? Replace 3 methods in RCTTiming.m like https://github.com/facebook/react-native/pull/25164/files#diff-29f34a4d1c9b73a44351941dae6056c8R174-R202, and try wether it crashed on iOS 13.1. Thanks.

bobber205 · 2019-11-02T05:35:13Z

I can try next week

…

On Fri, Nov 1, 2019, 8:46 PM Wu Zhong ***@***.***> wrote: I reviewed the timer module again, I may suspect there have thread-safe issue, @bobber205 <https://github.com/bobber205> @oleksandr-dziuban <https://github.com/oleksandr-dziuban> can you guys can help to dig in? Replace 3 methods in RCTTiming.m like https://github.com/facebook/react-native/pull/25164/files#diff-29f34a4d1c9b73a44351941dae6056c8R174-R202, and try wether it crashed on iOS 13.1. Thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#26696?email_source=notifications&email_token=ABMSBU74VOQGEJALVOSHKYDQRTZZLA5CNFSM4I44TOJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC4S52A#issuecomment-549007080>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMSBU3CEMWRTSY3TS6BAOTQRTZZLANCNFSM4I44TOJQ> .

radko93 · 2019-11-04T20:18:10Z

You can now try 0.61.4 as it includes a fix.

…27073) Summary: This PR reverts commit 3382984 that is causing #26696 #26995. > app would be closed immediately after going to background on iOS 13.1/13.2 and was investigated by minhtc #26696 (comment). The commit that is being reverted is apparently causing the app to be closed immediately. This has to be reverted in master separately as the file differs there. Similar PR for 0.61. branch #27065 ## Changelog [iOS] [Fixed] - Fix apps crashing on iOS 13.x when running timer in the background Pull Request resolved: #27073 Test Plan: Try [this](3382984#commitcomment-35745287) snippet on iOS 13.1/13.2, the app should not crash anymore Differential Revision: D18323679 Pulled By: cpojer fbshipit-source-id: 3af7036a0e1d3811924e581c649b16e5a4667e83

radko93 · 2019-11-05T17:09:24Z

This is now fixed on 61 branch and on master.

sarthak-synclovis · 2020-01-10T12:02:52Z

Still having same issue. Works fine on simulators as well devices upto iPhone 8. For devices of X series, crash is happening still after 2-3 minutes

octodhruv · 2020-01-22T11:32:02Z

any other ideas what could cause this? Upgrading to .61.5 didn't fix this for me :/

vforvasile · 2020-02-03T12:06:51Z

@sarthak216-blr , @octodhruv are you guys using Websockets?

octodhruv · 2020-02-03T12:24:23Z

@vforvasile Nope - no websockets.

unalkiran · 2020-02-19T07:56:26Z

1- app closed (not in background)
2- received a notification
3- click app icon or click notification for launch
4- app crashes at didFinishLaunchingWithOptions. cause RCTCxxBridge _handleError.
5- kill app and launch again, app is opening without error !

iOS 13.3.1 (iPhone 11)
RN 0.61.5

can anyone help?

terijyu · 2020-03-11T18:38:40Z

This is causing serious issues for us as well @radko93

hugw · 2020-04-29T17:15:25Z

@vforvasile @radko93 Hi. I'm curious why you asked if we are using Websockets. Could you provide more details on how would that cause the problem?

skyfx64 · 2020-08-12T01:55:57Z

I have exactly the same issue and currently fix it with RN 0.61.5, but when using 0.61.4 sometimes unstable.

bobber205 added the Bug label Oct 2, 2019

react-native-bot added the Platform: iOS iOS applications. label Oct 2, 2019

react-native-bot added Ran Commands One of our bots successfully processed a command. Resolution: Needs More Information labels Oct 2, 2019

oleksandr-dziuban mentioned this issue Oct 8, 2019

App freezes when focus TextInput #26707

Closed

radko93 mentioned this issue Oct 30, 2019

Reverts "Timing: Fixes timer when app get into background (#24649)" #27065

Merged

This was referenced Oct 31, 2019

App terminated in background when WebSocket is open #26731

Closed

[iOS] setInterval/setTimeout causes the app to crash, May be the problem with RCTTiming.m #26995

Closed

radko93 added a commit that referenced this issue Oct 31, 2019

Reverts "Timing: Fixes timer when app get into background (#24649)"

d44e3fc

This PR reverts commit 3382984 that is causing #26696 #26995.

radko93 added a commit that referenced this issue Oct 31, 2019

Reverts "Timing: Fixes timer when app get into background (#24649)"

406c573

This PR reverts commit 3382984 that is causing #26696 #26995.

radko93 added a commit that referenced this issue Oct 31, 2019

Update RCTTiming.mm

4a1ef65

This PR reverts commit 3382984 that is causing #26696 #26995.

radko93 mentioned this issue Oct 31, 2019

Reverts "Timing: Fixes timer when app get into background (#24649)" #27073

Closed

esamelson mentioned this issue Nov 1, 2019

[ios][sdk36] revert timer commit in RN 0.61 that causes a crash on iOS 13.1/13.2 expo/expo#6150

Closed

narobertson42 mentioned this issue Nov 4, 2019

0.61.3 Discussion react-native-community/releases#150

Closed

radko93 closed this as completed Nov 5, 2019

facebook locked as resolved and limited conversation to collaborators Oct 3, 2021

react-native-bot added the Resolution: Locked This issue was locked by the bot. label Oct 3, 2021

React Native 0.61.1 and iOS 13.1.2 leads to lots of unneeded relaunches of our app #26696

React Native 0.61.1 and iOS 13.1.2 leads to lots of unneeded relaunches of our app #26696

Comments

bobber205 commented Oct 2, 2019

react-native-bot commented Oct 2, 2019

radko93 commented Oct 3, 2019

bobber205 commented Oct 3, 2019 • edited Loading

oleksandr-dziuban commented Oct 7, 2019 • edited Loading

bobber205 commented Oct 7, 2019

radko93 commented Oct 8, 2019

oleksandr-dziuban commented Oct 8, 2019 • edited Loading

oleksandr-dziuban commented Oct 8, 2019 • edited Loading

oleksandr-dziuban commented Oct 8, 2019 • edited Loading

radko93 commented Oct 8, 2019

oleksandr-dziuban commented Oct 8, 2019

oleksandr-dziuban commented Oct 8, 2019 • edited Loading

radko93 commented Oct 8, 2019 • edited Loading

oleksandr-dziuban commented Oct 8, 2019 • edited Loading

oleksandr-dziuban commented Oct 8, 2019

oleksandr-dziuban commented Oct 8, 2019 • edited Loading

SYoder1 commented Oct 8, 2019

bobber205 commented Oct 8, 2019

bobber205 commented Oct 8, 2019

SYoder1 commented Oct 8, 2019

oleksandr-dziuban commented Oct 8, 2019 • edited Loading

ozgursoy commented Oct 8, 2019 • edited Loading

oleksandr-dziuban commented Oct 8, 2019

oleksandr-dziuban commented Oct 8, 2019 • edited Loading

bobber205 commented Oct 8, 2019

radko93 commented Oct 30, 2019

bobber205 commented Oct 30, 2019

radko93 commented Oct 30, 2019 • edited Loading

zhongwuzw commented Nov 2, 2019

zhongwuzw commented Nov 2, 2019

bobber205 commented Nov 2, 2019 via email

radko93 commented Nov 4, 2019

radko93 commented Nov 5, 2019

sarthak-synclovis commented Jan 10, 2020 • edited Loading

octodhruv commented Jan 22, 2020

vforvasile commented Feb 3, 2020

octodhruv commented Feb 3, 2020

unalkiran commented Feb 19, 2020 • edited Loading

terijyu commented Mar 11, 2020

hugw commented Apr 29, 2020

skyfx64 commented Aug 12, 2020

bobber205 commented Oct 3, 2019 •

edited

Loading

oleksandr-dziuban commented Oct 7, 2019 •

edited

Loading

oleksandr-dziuban commented Oct 8, 2019 •

edited

Loading

oleksandr-dziuban commented Oct 8, 2019 •

edited

Loading

oleksandr-dziuban commented Oct 8, 2019 •

edited

Loading

oleksandr-dziuban commented Oct 8, 2019 •

edited

Loading

radko93 commented Oct 8, 2019 •

edited

Loading

oleksandr-dziuban commented Oct 8, 2019 •

edited

Loading

oleksandr-dziuban commented Oct 8, 2019 •

edited

Loading

oleksandr-dziuban commented Oct 8, 2019 •

edited

Loading

ozgursoy commented Oct 8, 2019 •

edited

Loading

oleksandr-dziuban commented Oct 8, 2019 •

edited

Loading

radko93 commented Oct 30, 2019 •

edited

Loading

sarthak-synclovis commented Jan 10, 2020 •

edited

Loading

unalkiran commented Feb 19, 2020 •

edited

Loading