-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix - argument type in RCTEventEmitter
Reviewed By: javache Differential Revision: D6528139 fbshipit-source-id: 170c2359bcc67131330d091e3707124018053938
- Loading branch information
1 parent
fbf0aed
commit eaa8499
Showing
2 changed files
with
5 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaa8499
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without detailed motivation in commit message, this change looks very strange... even more, it looks dangerous... what if one pass 1e100 as argument, what to do with that? what exact number is? What if one pass 1.5? This should be error, but it will not...
Very bad 👎
eaa8499
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, WTF? How can there be a listener count of 1.5?
This commit does not make any sense.