Skip to content

Commit

Permalink
Partially back out #24506, fixing iOS e2e tests (#24788)
Browse files Browse the repository at this point in the history
Summary:
The iOS End-to-End tests started failing with the updates made to the iOS template's Podfile in 261197d. Undoing these gets our CI iOS e2e test step back to green.

[iOS] [Removed] - Revert auto-linking related changes to the iOS template Podfile
Pull Request resolved: #24788

Differential Revision: D15317895

Pulled By: cpojer

fbshipit-source-id: a1f3b84b39c6d341740f742d83fd05a1ab841184
  • Loading branch information
hramos authored and facebook-github-bot committed May 13, 2019
1 parent 0245fd7 commit da7d3df
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
14 changes: 12 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -499,12 +499,22 @@ jobs:

- run:
name: Run JavaScript End-to-End Tests
command: node ./scripts/run-ci-e2e-tests.js --js --retries 3
command: |
# free up port 8081 for the packager before running tests
set +eo pipefail
lsof -i tcp:8081 | awk 'NR!=1 {print $2}' | xargs kill
set -eo pipefail
node ./scripts/run-ci-e2e-tests.js --js --retries 3
when: always

- run:
name: Run iOS End-to-End Tests
command: node ./scripts/run-ci-e2e-tests.js --ios --retries 3;
command: |
# free up port 8081 for the packager before running tests
set +eo pipefail
lsof -i tcp:8081 | awk 'NR!=1 {print $2}' | xargs kill
set -eo pipefail
node ./scripts/run-ci-e2e-tests.js --ios --retries 3;
when: always


Expand Down
2 changes: 0 additions & 2 deletions template/ios/Podfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
platform :ios, '9.0'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

target 'HelloWorld' do
# Pods for HelloWorld
Expand Down Expand Up @@ -33,7 +32,6 @@ target 'HelloWorld' do
# Pods for testing
end

use_native_modules!
end

target 'HelloWorld-tvOS' do
Expand Down

0 comments on commit da7d3df

Please sign in to comment.