Skip to content

Commit

Permalink
Upgrade to Flow v0.108.0
Browse files Browse the repository at this point in the history
Reviewed By: gabelevi

Differential Revision: D17488182

fbshipit-source-id: e67c5bcbd9f0bda49d52531387d92d7c83a01f21
  • Loading branch information
mvitousek authored and facebook-github-bot committed Sep 20, 2019
1 parent e0ea5b3 commit d34bc5f
Show file tree
Hide file tree
Showing 9 changed files with 15 additions and 28 deletions.
2 changes: 1 addition & 1 deletion .flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -79,4 +79,4 @@ untyped-import
untyped-type-import

[version]
^0.107.0
^0.108.0
2 changes: 1 addition & 1 deletion .flowconfig.android
Original file line number Diff line number Diff line change
Expand Up @@ -79,4 +79,4 @@ untyped-import
untyped-type-import

[version]
^0.107.0
^0.108.0
3 changes: 3 additions & 0 deletions Libraries/Lists/VirtualizedList.js
Original file line number Diff line number Diff line change
Expand Up @@ -1859,6 +1859,9 @@ class CellRenderer extends React.Component<
}

if (ListItemComponent) {
/* $FlowFixMe(>=0.108.0 site=react_native_fb) This comment suppresses an
* error found when Flow v0.108 was deployed. To see the error, delete
* this comment and run Flow. */
return React.createElement(ListItemComponent, {
item,
index,
Expand Down
4 changes: 2 additions & 2 deletions Libraries/Sample/Sample.android.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ const warning = require('fbjs/lib/warning');

const Sample = {
test: function() {
/* $FlowFixMe(>=0.106.0 site=react_native_android_fb) This comment
* suppresses an error found when Flow v0.106 was deployed. To see the
/* $FlowFixMe(>=0.108.0 site=react_native_android_fb) This comment
* suppresses an error found when Flow v0.108 was deployed. To see the
* error, delete this comment and run Flow. */
warning('Not yet implemented for Android.');
},
Expand Down
14 changes: 2 additions & 12 deletions RNTester/js/RNTesterApp.android.js
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,7 @@ const RNTesterExampleContainerViaHook = ({
return (
<RNTesterThemeContext.Provider value={theme}>
<View style={styles.container}>
<Header
title={title}
/* $FlowFixMe(>=0.78.0 site=react_native_android_fb) This issue
* was found when making Flow check .android.js files. */
onPressDrawer={onPressDrawer}
/>
<Header title={title} onPressDrawer={onPressDrawer} />
<RNTesterExampleContainer module={module} ref={exampleRef} />
</View>
</RNTesterThemeContext.Provider>
Expand Down Expand Up @@ -161,12 +156,7 @@ const RNTesterExampleListViaHook = ({
return (
<RNTesterThemeContext.Provider value={theme}>
<View style={styles.container}>
<Header
title={title}
/* $FlowFixMe(>=0.78.0 site=react_native_android_fb) This issue
* was found when making Flow check .android.js files. */
onPressDrawer={onPressDrawer}
/>
<Header title={title} onPressDrawer={onPressDrawer} />
<RNTesterExampleList onNavigate={onNavigate} list={list} />
</View>
</RNTesterThemeContext.Provider>
Expand Down
6 changes: 0 additions & 6 deletions RNTester/js/examples/TextInput/TextInputExample.android.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,6 @@ class TextEventsExample extends React.Component<{}, $FlowFixMeState> {
}

class RewriteExample extends React.Component<$FlowFixMeProps, $FlowFixMeState> {
/* $FlowFixMe(>=0.85.0 site=react_native_android_fb) This comment suppresses
* an error found when Flow v0.85 was deployed. To see the error, delete this
* comment and run Flow. */
constructor(props) {
super(props);
this.state = {text: ''};
Expand Down Expand Up @@ -124,9 +121,6 @@ class TokenizedTextExample extends React.Component<
$FlowFixMeProps,
$FlowFixMeState,
> {
/* $FlowFixMe(>=0.85.0 site=react_native_android_fb) This comment suppresses
* an error found when Flow v0.85 was deployed. To see the error, delete this
* comment and run Flow. */
constructor(props) {
super(props);
this.state = {text: 'Hello #World'};
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
"eslint-plugin-react-hooks": "^2.0.1",
"eslint-plugin-react-native": "3.6.0",
"eslint-plugin-relay": "1.3.11",
"flow-bin": "^0.107.0",
"flow-bin": "^0.108.0",
"flow-remove-types": "1.2.3",
"jest": "^24.8.0",
"jest-junit": "^6.3.0",
Expand Down
2 changes: 1 addition & 1 deletion template/_flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,4 @@ untyped-import
untyped-type-import

[version]
^0.107.0
^0.108.0
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3188,10 +3188,10 @@ flat-cache@^1.2.1:
rimraf "~2.6.2"
write "^0.2.1"

flow-bin@^0.107.0:
version "0.107.0"
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.107.0.tgz#b37bfcce51204d35d58f8eb93b3a76b52291e4cc"
integrity sha512-hsmwO5Q0+XUXaO2kIKLpleUNNBSFcsGEQGBOTEC/KR/4Ez695I1fweX/ioSjbU4RWhPZhkIqnpbF9opVAauCHg==
flow-bin@^0.108.0:
version "0.108.0"
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.108.0.tgz#6a42c85fd664d23dd937d925851e8e6ab5d71393"
integrity sha512-hPEyCP1J8rdhNDfCAA5w7bN6HUNBDcHVg/ABU5JVo0gUFMx+uRewpyEH8LlLBGjVQuIpbaPpaqpoaQhAVyaYww==

flow-parser@0.*:
version "0.89.0"
Expand Down

0 comments on commit d34bc5f

Please sign in to comment.