Refactor IPerformanceLogger as an interface

Summary:
This type makes more sense as an interface, given a class would be a common implementation (and object types aren't supported in that case).

It also adds the names of the parameters so it's easier to understand for implementers.

Changelog:
[General][Changed] - Changed type definition of IPerformanceLogger from object to interface

Reviewed By: lunaleaps

Differential Revision: D23449816

fbshipit-source-id: be872748827b123587f3f397da20f5545b0aae07

Libraries/Utilities/createPerformanceLogger.js

@@ -24,24 +24,32 @@ type Timespan = {
   ...
 };
 
-export type IPerformanceLogger = {
-  addTimeAnnotation(string, number, string | void): void,
-  addTimespan(string, number, number, string | void): void,
-  startTimespan(string, string | void): void,
-  stopTimespan(string, options?: {update?: boolean}): void,
-  clear(): void,
-  clearCompleted(): void,
-  currentTimestamp(): number,
-  getTimespans(): {[key: string]: Timespan, ...},
-  hasTimespan(string): boolean,
-  setExtra(string, mixed): void,
-  getExtras(): {[key: string]: mixed, ...},
-  removeExtra(string): ?mixed,
-  markPoint(string, number | void): void,
-  getPoints(): {[key: string]: number, ...},
-  logEverything(): void,
-  ...
-};
+export interface IPerformanceLogger {
+  addTimeAnnotation(
+    key: string,
+    durationInMs: number,
+    description?: string,
+  ): void;
+  addTimespan(
+    key: string,
+    startTime: number,
+    endTime: number,
+    description?: string,
+  ): void;
+  startTimespan(key: string, description?: string): void;
+  stopTimespan(key: string, options?: {update?: boolean}): void;
+  clear(): void;
+  clearCompleted(): void;
+  currentTimestamp(): number;
+  getTimespans(): {[key: string]: Timespan, ...};
+  hasTimespan(key: string): boolean;
+  setExtra(key: string, value: mixed): void;
+  getExtras(): {[key: string]: mixed, ...};
+  removeExtra(key: string): ?mixed;
+  markPoint(key: string, timestamp?: number): void;
+  getPoints(): {[key: string]: number, ...};
+  logEverything(): void;
+}
 
 const _cookies: {[key: string]: number, ...} = {};