Skip to content

Commit

Permalink
Remove Okhttp3 Android Proguard Rules (#30514)
Browse files Browse the repository at this point in the history
Summary:
Remove proguard keep rules on okhttp3. The library already contains its own consumer proguard --> see https://square.github.io/okhttp/r8_proguard/

The keep rules will increase the final apk size of android app. Currently, there is no way to disable proguard rules from transitive dependencies ( https://issuetracker.google.com/issues/37073777). So any android app that use react native will also contains this proguard rules.

## Changelog

[Android] [Removed] - Remove okhttp3 proguard rules

Pull Request resolved: #30514

Test Plan: n/a

Reviewed By: mdvacca

Differential Revision: D25616704

Pulled By: fkgozali

fbshipit-source-id: eb0bcbc4ace398a55ce6902e34c17b030bb87130
  • Loading branch information
doniwinata0309 authored and facebook-github-bot committed Dec 17, 2020
1 parent 8c8172f commit b4c9f13
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions ReactAndroid/proguard-rules.pro
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,6 @@
# hermes
-keep class com.facebook.jni.** { *; }

# okhttp

-keepattributes Signature
-keepattributes *Annotation*
-keep class okhttp3.** { *; }
-keep interface okhttp3.** { *; }
-dontwarn okhttp3.**

# okio

Expand Down

0 comments on commit b4c9f13

Please sign in to comment.