Skip to content

Commit

Permalink
Update ignore file to include ReactBuildConfig in the npm package (#…
Browse files Browse the repository at this point in the history
…45279)

Summary:
Changes `.npmignore` file to only exclude the `ReactAndroid/build` directory instead of all `build` directories under `ReactAndroid` (which included the `ReactAndroid/src/main/java/com/facebook/react/common/build` package). This problem was caused by the newer version of NPM being used.

Closes #45204

## Changelog:

[ANDROID] [FIXED] - Fixed build from source failing due to a missing file

Pull Request resolved: #45279

Test Plan:
Run `npm pack` or `npm publish -dry-run`.

Before this change it includes 3774 files in the package and `ReactBuildConfig` isn't included. After this change it includes 3775 files in the package and `ReactBuildConfig` is included.

Reviewed By: javache

Differential Revision: D59371555

Pulled By: cortinico

fbshipit-source-id: f54f1e88e30429d538b9e160e6ce20d994c5d1b8
  • Loading branch information
j-piasecki authored and facebook-github-bot committed Jul 4, 2024
1 parent f1b6218 commit b289854
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/react-native/ReactAndroid/.npmignore
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Make sure we never publish ReactAndroid/build (Gradle output)
# or ReactAndroid/.cxx (CMake output) to npm.
# Those folders are huge (> 100MB)!
build/
/build/
.cxx/
# Exclude buck config/jars for third-party libraries
src/main/third-party/
Expand Down

0 comments on commit b289854

Please sign in to comment.