Skip to content

Commit

Permalink
Replace Paper -> old renderer
Browse files Browse the repository at this point in the history
Summary:
Replace Paper -> old renderer

changelog: [internal] internal

Reviewed By: sammy-SC

Differential Revision: D30139941

fbshipit-source-id: 3bb1e81a3df018aa669f3dba1de445107d70116c
  • Loading branch information
mdvacca authored and facebook-github-bot committed Aug 6, 2021
1 parent cf717ff commit 91437d6
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ std::string componentNameByReactViewName(std::string viewName) {
}

// TODO T63839307: remove this condition after deleting TextInlineImage from
// non-Fabric code
// old renderer code
if (viewName == "TextInlineImage") {
return "Image";
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ class YogaLayoutableShadowNode : public LayoutableShadowNode {
* - borderBottom(Left|Right)Radius → borderBottom(Start|End)Radius
* - border(Left|Right)Width → border(Start|End)Width
* - border(Left|Right)Color → border(Start|End)Color
* This is neccesarry to be backwards compatible with Paper, it swaps the
* values as well in https://fburl.com/diffusion/kl7bjr3h
* This is neccesarry to be backwards compatible with old renderer, it swaps
* the values as well in https://fburl.com/diffusion/kl7bjr3h
*/
static void swapLeftAndRightInTree(
YogaLayoutableShadowNode const &shadowNode);
Expand Down
4 changes: 2 additions & 2 deletions ReactCommon/react/renderer/core/ComponentDescriptor.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ class ComponentDescriptor {
* and `ComponentHandle` (the particular custom implementation might use
* stored `flavor` to return different values from those virtual methods).
* Since it's a very niche requirement (e.g. we plan to use it for
* an interoperability layer with Paper), we are thinking about removing this
* feature completely after it's no longer needed.
* an interoperability layer with old renderer), we are thinking about
* removing this feature completely after it's no longer needed.
*/
using Flavor = std::shared_ptr<void const>;

Expand Down

0 comments on commit 91437d6

Please sign in to comment.