Skip to content

Commit

Permalink
Deprecate CallerContext from ReactImageManager
Browse files Browse the repository at this point in the history
Summary:
This diff deprecates the constructors and getter method exposing CallerContext in ReactImageManager.
This will be replaced by the ReactCallerContextFactory class

Changelog: Deprecation of constructors and methods that expose CallerContext in ReactImageManager class

Reviewed By: JoshuaGross

Differential Revision: D18474012

fbshipit-source-id: d8190f938e00da0499bfef7e81522dc8022a8836
  • Loading branch information
mdvacca authored and facebook-github-bot committed Nov 16, 2019
1 parent 882e4a3 commit 8accd77
Showing 1 changed file with 12 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,22 @@ public String getName() {
private final @Nullable Object mCallerContext;
private final @Nullable ReactCallerContextFactory mCallerContextFactory;

/**
* @deprecated use {@link ReactImageManager#ReactImageManager(AbstractDraweeControllerBuilder,
* ReactCallerContextFactory)} instead.
*/
@Deprecated
public ReactImageManager(
@Nullable AbstractDraweeControllerBuilder draweeControllerBuilder,
@Nullable Object callerContext) {
this(draweeControllerBuilder, null, callerContext);
}

/**
* @deprecated use {@link ReactImageManager#ReactImageManager(AbstractDraweeControllerBuilder,
* GlobalImageLoadListener, ReactCallerContextFactory)} instead.
*/
@Deprecated
public ReactImageManager(
@Nullable AbstractDraweeControllerBuilder draweeControllerBuilder,
@Nullable GlobalImageLoadListener globalImageLoadListener,
Expand Down Expand Up @@ -87,6 +97,8 @@ public AbstractDraweeControllerBuilder getDraweeControllerBuilder() {
return mDraweeControllerBuilder;
}

/** @deprecated use {@link ReactCallerContextFactory} instead */
@Deprecated
public Object getCallerContext() {
return mCallerContext;
}
Expand Down

0 comments on commit 8accd77

Please sign in to comment.