Skip to content

Commit

Permalink
Delete RCTBatchedBridge
Browse files Browse the repository at this point in the history
Summary:
I've talked to several major community users, and they're all ok with deleting this
code.  There's several doc fixes which will make it easier for third
party developers which should land about the same time this will.

Also buried along with it is RCTJSCExecutor.

Reviewed By: javache

Differential Revision: D6880781

fbshipit-source-id: b4cb1143def6fd23a96290e478fa728adbedacd3
  • Loading branch information
mhorowitz authored and facebook-github-bot committed Feb 5, 2018
1 parent 108f966 commit 816d417
Show file tree
Hide file tree
Showing 23 changed files with 22 additions and 8,845 deletions.
2,186 changes: 0 additions & 2,186 deletions RNTester/RNTesterLegacy.xcodeproj/project.pbxproj

This file was deleted.

This file was deleted.

This file was deleted.

6 changes: 3 additions & 3 deletions RNTester/RNTesterUnitTests/RCTAllocationTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -184,16 +184,16 @@ - (void)testUnderlyingBridgeIsDeallocated
@autoreleasepool {
bridge = [[RCTBridge alloc] initWithBundleURL:_bundleURL moduleProvider:nil launchOptions:nil];
batchedBridge = bridge.batchedBridge;
XCTAssertTrue([batchedBridge isValid], @"RCTBatchedBridge should be valid");
XCTAssertTrue([batchedBridge isValid], @"RCTBridge impl should be valid");
[bridge reload];
}

RCT_RUN_RUNLOOP_WHILE(batchedBridge != nil)

XCTAssertNotNil(bridge, @"RCTBridge should not have been deallocated");
XCTAssertNil(batchedBridge, @"RCTBatchedBridge should have been deallocated");
XCTAssertNil(batchedBridge, @"RCTBridge impl should have been deallocated");

// Wait to complete the test until the new batchedbridge is also deallocated
// Wait to complete the test until the new bridge impl is also deallocated
@autoreleasepool {
batchedBridge = bridge.batchedBridge;
[bridge invalidate];
Expand Down
Loading

0 comments on commit 816d417

Please sign in to comment.