Skip to content

Commit

Permalink
ios-simulator: change default iphone version (#21148)
Browse files Browse the repository at this point in the history
Summary:
this is just a suggestion, but as the iPhone 6 is discontinued by Apple
and the new iPhone line will match the X version, it could be good to update the default simulator.

it could also be the iPhone 8, feel free to suggest other changes!

Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change.

If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
Pull Request resolved: #21148

Differential Revision: D9928120

Pulled By: hramos

fbshipit-source-id: 005faa3a8e00b67f98a778c92ecc01b064e14199
  • Loading branch information
Vitor Capretz authored and facebook-github-bot committed Sep 19, 2018
1 parent 9fca769 commit 6d09df5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion local-cli/runIOS/runIOS.js
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ module.exports = {
{
command: '--simulator [string]',
description: 'Explicitly set simulator to use',
default: 'iPhone 6',
default: 'iPhone X',
},
{
command: '--configuration [string]',
Expand Down

1 comment on commit 6d09df5

@kaushalpar
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello after replace(default: 'iPhone X') not working displayed message is Could not find iPhone X simulator how to resolved this issue. this type issue found 90% github project.

Please sign in to comment.