-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
RN: Refine
StyleSheet.compose
Flow Type
Summary: Refines `StyleSheet.compose` so that subtypes of `DangerouslyImpreciseStyleProp` can flow through the function call without losing their type. This makes it so that if you supply two `ViewStyleProp` types, you will get a `ViewStyleProp` type out of it. Reviewed By: TheSavior Differential Revision: D8851699 fbshipit-source-id: e38e572e363a71fddf63d6b6bf5a96b3cdae5915
- Loading branch information
1 parent
732c3a4
commit 50a481d
Showing
2 changed files
with
87 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
/** | ||
* Copyright (c) 2015-present, Facebook, Inc. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
* @flow strict-local | ||
* @format | ||
*/ | ||
|
||
'use strict'; | ||
|
||
const StyleSheet = require('StyleSheet'); | ||
|
||
import type {ImageStyleProp, TextStyleProp} from 'StyleSheet'; | ||
|
||
const imageStyle = {tintColor: 'rgb(0, 0, 0)'}; | ||
const textStyle = {color: 'rgb(0, 0, 0)'}; | ||
|
||
module.exports = { | ||
testGoodCompose() { | ||
(StyleSheet.compose( | ||
imageStyle, | ||
imageStyle, | ||
): ImageStyleProp); | ||
|
||
(StyleSheet.compose( | ||
textStyle, | ||
textStyle, | ||
): TextStyleProp); | ||
|
||
(StyleSheet.compose( | ||
null, | ||
null, | ||
): TextStyleProp); | ||
|
||
(StyleSheet.compose( | ||
textStyle, | ||
null, | ||
): TextStyleProp); | ||
|
||
(StyleSheet.compose( | ||
textStyle, | ||
Math.random() < 0.5 ? textStyle : null, | ||
): TextStyleProp); | ||
|
||
(StyleSheet.compose( | ||
[textStyle], | ||
null, | ||
): TextStyleProp); | ||
|
||
(StyleSheet.compose( | ||
[textStyle], | ||
null, | ||
): TextStyleProp); | ||
|
||
(StyleSheet.compose( | ||
[textStyle], | ||
[textStyle], | ||
): TextStyleProp); | ||
}, | ||
|
||
testBadCompose() { | ||
// $FlowExpectedError - Incompatible type. | ||
(StyleSheet.compose( | ||
textStyle, | ||
textStyle, | ||
): ImageStyleProp); | ||
|
||
(StyleSheet.compose( | ||
// $FlowExpectedError - Incompatible type. | ||
[textStyle], | ||
null, | ||
): ImageStyleProp); | ||
|
||
// $FlowExpectedError - Incompatible type. | ||
(StyleSheet.compose( | ||
Math.random() < 0.5 ? textStyle : null, | ||
null, | ||
): ImageStyleProp); | ||
}, | ||
}; |