Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Removing <TextInput>'s
onTextInput
event
Summary: This is the first diff in the series. It removes Flow types for this feature to verify that we actually do not have any usages. After it lands, we will remove actual support on the native side. There are several reasons why removing it is a good idea: * There is no any evidence that this feature is actually useful. That was discussed several times (e.g. see T7936714) during RN lifetime and the overall consensus is: We need something else, something like sync `onChange` event instead of it. * Supporting the previous point, it's not used (at least inside Facebook). I searched hard and I could find only one place where it's used: in the TextInput Example. * To deliver more functionality we should lean towards W3C specs, this one is not W3C compliant. * Supporting this Feature in Fabric is quite challenging, so I want to do it sooner than later. * This feature was never documented. Changelog: [Breaking] `<TextInput>::onTextInput` event was removed Reviewed By: TheSavior Differential Revision: D18456175 fbshipit-source-id: c7a8ed7a86b33ecc01d45497645fe249556fdf96
- Loading branch information
3f7e0a2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shergin With this change we have to rely on
onChange
oronChangeText
neither of which carries therange
attribute thatTextInputEvent
had. As far as I see it there's also no easy way to get it otherwise (without guessing). This breaks our rich text editor we've built internally, that needs the range to i.e. handle autocorrect and other things.