-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Pass node executable to codegen (#33672)
Summary: Pull Request resolved: #33672 This pr adds a parameter to the `create-artifacts.js` script to accept the path to a node executable, falling back to `node` in case the parameter has not been passed. Then, it passes the NODE_BINARY to the script in the `script_phases.sh` script. This PR decouples the `node` environment from the system one and fixes a build issue in the new architecture when the environment has no `node` ## Changelog [iOS][Changed] - Update CodeGen scripts to accept custom node executable Reviewed By: cortinico, dmitryrykun Differential Revision: D35748497 fbshipit-source-id: 41b102de6427d6ef0ba1f8725f4b939d3b8c63db
- Loading branch information
1 parent
705c6f5
commit 323db75
Showing
2 changed files
with
17 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters