Update to Detox 9 (#21570)

Summary:
Updating to Detox 9 - this should help with better Xcode 10 support, and should fix #21539.

I've updated to fixed `9.0.4` since it seems that each version is fairly different from the next, and I've followed the [migration guide](https://github.com/wix/detox/blob/master/docs/Guide.Migration.md#migrating-from-detox-8xx-to-9xx) for the android native dependencies.

Release Notes:

[INTERNAL] [ENHANCEMENT] [DETOX] - Update to version 9.0.4

Pull Request resolved: #21570

Reviewed By: TheSavior

Differential Revision: D10242373

Pulled By: RSNara

fbshipit-source-id: bd29d554e0972f16d96b9b39b86c7143941d5b7c

ReactAndroid/build.gradle

@@ -315,7 +315,8 @@ dependencies {
     testImplementation "org.robolectric:robolectric:${ROBOLECTRIC_VERSION}"
 
     androidTestImplementation fileTree(dir: 'src/main/third-party/java/buck-android-support/', include: ['*.jar'])
-    androidTestImplementation 'com.android.support.test:runner:0.3'
+    androidTestImplementation "com.android.support.test:runner:${ANDROID_SUPPORT_TEST_VERSION}"
+    androidTestImplementation "com.android.support.test:rules:${ANDROID_SUPPORT_TEST_VERSION}"
     androidTestImplementation "org.mockito:mockito-core:${MOCKITO_CORE_VERSION}"
 }
 

ReactAndroid/gradle.properties

@@ -11,6 +11,7 @@ ROBOLECTRIC_VERSION=3.0
 JUNIT_VERSION=4.12
 FEST_ASSERT_CORE_VERSION=2.0M10
 
+ANDROID_SUPPORT_TEST_VERSION=1.0.2
 FRESCO_VERSION=1.10.0
 OKHTTP_VERSION=3.10.0
 

package.json

@@ -209,7 +209,7 @@
     "async": "^2.4.0",
     "babel-eslint": "9.0.0",
     "babel-generator": "^6.26.0",
-    "detox": "^8.2.3",
+    "detox": "9.0.4",
     "eslint": "5.1.0",
     "eslint-config-fb-strict": "22.1.0",
     "eslint-config-fbjs": "2.0.1",