Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add extensibility point on react-native-xcode.sh script
Summary: Original pull request: #12863 Useful for generating source maps, for example. Feature parity with Android, that already have this extensibility point on `build.gradle`: ``` project.ext.react = [ extraPackagerArgs: [...] ] ``` Xcode > Build Phases > Bundle React Native code and Images ``` export NODE_BINARY=node export EXTRA_PACKAGER_ARGS="--sourcemap-output ${SRCROOT}/build/main.jsbundle.map" ../node_modules/react-native/scripts/react-native-xcode.sh ``` [IOS] [FEATURE] [./react-native-xcode.sh] - Added $EXTRA_PACKAGER_ARGS extensibility point Closes #16933 Differential Revision: D6771709 Pulled By: yungsters fbshipit-source-id: a33614b45b1e3537daeb31504fdd3a402dc70ff0
- Loading branch information
1 parent
bcfbdf4
commit 0d4ff1b
0d4ff1bThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hramos original PR was to change something. seems like the import deleted the entire file.
0d4ff1bThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep cc @yungsters.
The PR is just one line change, not idea why this happened when the bot imported.
PS: although the first line says PR 12683 the correct one is #16933.
0d4ff1bThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See b8c86b8.