Skip to content

Commit

Permalink
Declare all attrs used in res targets (#29794)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #29794

Per title - need to declare deps of attrs that we are using (soon Buck will enforce this).

Changelog: declare dependencies of all attributes that are used in the resource target.

Reviewed By: jiawei-lyu

Differential Revision: D23388058

fbshipit-source-id: b395d153188f75f8c0d4a6d69302812a56b23925
  • Loading branch information
IanChilds authored and facebook-github-bot committed Aug 31, 2020
1 parent 6d3dcc7 commit 05abbd2
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion ReactAndroid/src/main/res/BUCK
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_target", "rn_android_resource")
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_target", "rn_android_resource")

rn_android_resource(
name = "devsupport",
Expand All @@ -16,6 +16,9 @@ rn_android_resource(
visibility = [
"PUBLIC",
],
deps = [
react_native_dep("third-party/android/androidx:appcompat"),
],
)

rn_android_resource(
Expand Down

0 comments on commit 05abbd2

Please sign in to comment.