Skip to content

Commit

Permalink
Use relative path for SCRIPTDIR (#22598)
Browse files Browse the repository at this point in the history
Summary:
Fixes #22521

The current approach has an issue with white spaces when compiling in Xcode 10.1

![space](https://user-images.githubusercontent.com/615282/49782648-07836f80-fd52-11e8-952f-b93f8c593c60.png)

Change back to relative path fixes this issue
Pull Request resolved: #22598

Differential Revision: D13421446

Pulled By: hramos

fbshipit-source-id: 688157b2e951399059cb6c95e2a6ce8d176e9b9c
  • Loading branch information
sunnylqm authored and facebook-github-bot committed Dec 11, 2018
1 parent aeaeac8 commit 0314fca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/ios-install-third-party.sh
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ function fetch_and_unpack () {

mkdir -p third-party

SCRIPTDIR=$(cd $(dirname "$0") && pwd)
SCRIPTDIR=$(dirname "$0")

fetch_and_unpack glog-0.3.5.tar.gz https://github.com/google/glog/archive/v0.3.5.tar.gz 61067502c5f9769d111ea1ee3f74e6ddf0a5f9cc "\"$SCRIPTDIR/ios-configure-glog.sh\""
fetch_and_unpack double-conversion-1.1.6.tar.gz https://github.com/google/double-conversion/archive/v1.1.6.tar.gz 1c7d88afde3aaeb97bb652776c627b49e132e8e0
Expand Down

0 comments on commit 0314fca

Please sign in to comment.