Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration with Existing Apps: Podfile example does not use use_react_native!, is incomplete #2958

Open
mhjacobson opened this issue Feb 8, 2022 · 1 comment · May be fixed by #2962
Open

Integration with Existing Apps: Podfile example does not use use_react_native!, is incomplete #2958

mhjacobson opened this issue Feb 8, 2022 · 1 comment · May be fixed by #2962
Labels
👋 Good first issue Interested in collaborating? Take a stab at fixing one of these issues.

Comments

@mhjacobson
Copy link

Description

React Native 0.60 added the Podfile macro use_react_native!. In 0.63, the macro was added to the template project Podfile, replacing tens of pod lines in the Podfile of a React Native iOS app. (See the change in upgrade-helper.)

However, the Integration with Existing Apps docs page still suggests adding all the pod lines manually. (Worse, it is out of date, missing some pods that the reader basically just has to figure out through trial and error.)

The documentation should just suggest using use_react_native!, like the template project does.

Documentation version

next, 0.67
@mhjacobson mhjacobson changed the title Integration with Existing Apps: does not use use_react_native! Integration with Existing Apps: Podfile example does not use use_react_native!, is incomplete Feb 8, 2022
@cortinico
Copy link
Contributor

Yup you're right. That needs to be update.
That's up for grab if someone wants to contribute 👍

@cortinico cortinico added the 👋 Good first issue Interested in collaborating? Take a stab at fixing one of these issues. label Feb 8, 2022
mhjacobson added a commit to mhjacobson/react-native-website that referenced this issue Feb 9, 2022
@mhjacobson
Update Podspec directions to use use_react_native!
3817751 
Also, increase consistency between the Objective-C and Swift versions.

Fixes facebook#2958.
@mhjacobson mhjacobson linked a pull request Feb 9, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👋 Good first issue Interested in collaborating? Take a stab at fixing one of these issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Podspec directions to use use_react_native! mhjacobson/react-native-website
2 participants
@mhjacobson @cortinico