-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android P Fresco initialize #2115
Comments
Hi @dbeqiraj Thanks for reporting this issue. Could you provide more details so that we can reproduce it? Which device are you using and which Android P version? |
This is the code in my class@onCreate() which extends Application:
This happens in the emulator which runs Android API P x86. I have not tested it in a real device. |
Same issue on the Google Pixel (real device) with P(beta) Android. Fresco version 1.9.0. Initialization the same as above |
I use Fresco only to play a gif. This error doesn't look to affect that, looks fine. |
I didn't notice any side effects, only this error message, I use Fresco for simple image loading |
Summary: The nativeLoad method doesn't have the third argument in Android P, so it's causing an error in calling it from SoLoader (github issue for fresco: facebook/fresco#2115) - this diff fixes it. Reviewed By: erikandre Differential Revision: D8098159 fbshipit-source-id: df430028cff5941465a0f91800db55d498765a6c
He means on extends Application class init |
Same hear. I have Google Pixel gen1 with Android P. My project targets sdk28 and i use support libraries from AndroidX. This error crash my app. |
I fixed this error in soLoader here, so we should have it in place after the next soLoader release. The error will be gone only after Android P is officially released, since right now in beta there is still 27 returned for |
@zmroczek You are wrong. We have final API from yesterday and Android 9 beta 2 which returns Build.VERSION.SDK_INT = 28 and targetSdkVersion is unblocked to 28. Please, release new version as soon as possible. |
Ok, thanks for updating @dementia2029 in that case the soLoader fix I mentioned should help with that with beta 2. We'll update the version after the next soLoader release (should happen next week at the latest). |
We've updated the SoLoader version in 8e9243e, so the nativeLoad error shouldn't occur on Android P anymore. |
This problm also have emulator Nexus 5X API28 |
use below dependencies in your app gradle file : |
@zmroczek Under what circumstances do I need to update the version of this soLoader? We only used Fresco to load dynamic webp, and we haven't found any problems with this issue except for the warning message. So do we have to update the version of soLoader in Android P? |
@zmroczek |
Fresco version: 1.8.1
When I try to initialize it I get this error:
The text was updated successfully, but these errors were encountered: