Support globalThis proposal #7704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 tasks
chicoxyzzy
approved these changes
Jul 7, 2020
|
Hello |
|
This pull request has been merged in 0fe573e. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
Summary: In this diff, we add support for [`globalThis`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis). According to the spec, it refers to the global scope, which means that `globalThis.foo` means access of the `foo` global. In Flow, we can model it as a globally available namespace that contains all the other globals, plus the self referential `globalThis`. We only need to do it in type sig, since global libdef types are generated with type sig. In the validation of libdefs in checking, it will read the globalThis in the global libdef. Since there is no obvious location for this, I give it `Loc.none`. The tests added ensure that no IDE services will break. Close #7536 Close #7704 Changelog: [feature] Flow now supports [`globalThis`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis). Reviewed By: panagosg7 Differential Revision: D59083293 fbshipit-source-id: 57ed57d5ee5f369a3d707ba16e593d12d3720097
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: #7536
https://github.com/tc39/proposal-global